From patchwork Fri Aug 12 23:39:43 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 109909 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7BCD4B6F88 for ; Sat, 13 Aug 2011 09:39:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666Ab1HLXjh (ORCPT ); Fri, 12 Aug 2011 19:39:37 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:22705 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752534Ab1HLXjf (ORCPT ); Fri, 12 Aug 2011 19:39:35 -0400 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 8190B9403D; Sat, 13 Aug 2011 01:39:43 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 7AF479403B; Sat, 13 Aug 2011 01:39:43 +0200 (CEST) Date: Sat, 13 Aug 2011 01:39:43 +0200 (CEST) From: Jesper Juhl To: Krzysztof Halasa cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: [PATCH][Trivial] net/wan/hdlc_ppp: remove dead goto Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Juhl We'll either hit one of the case labels or the default in the switch and in all cases do we then 'goto out', so having 'goto out' right after the switch is pointless as we can never hit it - remove it. Signed-off-by: Jesper Juhl --- drivers/net/wan/hdlc_ppp.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c index 055a918..5385876 100644 --- a/drivers/net/wan/hdlc_ppp.c +++ b/drivers/net/wan/hdlc_ppp.c @@ -547,7 +547,6 @@ static int ppp_rx(struct sk_buff *skb) ppp_cp_event(dev, pid, RUC, 0, 0, len, cp); goto out; } - goto out; rx_error: dev->stats.rx_errors++;