From patchwork Mon Jun 20 22:13:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 101219 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6993CB6F82 for ; Tue, 21 Jun 2011 08:22:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756219Ab1FTWWA (ORCPT ); Mon, 20 Jun 2011 18:22:00 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:22690 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901Ab1FTWV6 (ORCPT ); Mon, 20 Jun 2011 18:21:58 -0400 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 71D3B9403D; Tue, 21 Jun 2011 00:13:11 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 631A09403B; Tue, 21 Jun 2011 00:13:11 +0200 (CEST) Date: Tue, 21 Jun 2011 00:13:10 +0200 (CEST) From: Jesper Juhl To: netdev@vger.kernel.org cc: "David S. Miller" , coreteam@netfilter.org, netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Kozlov Subject: [PATCH] Remove redundant linux/version.h includes from net/ Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It was suggested by "make versioncheck" that the follwing includes of linux/version.h are redundant: /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed. /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed. /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed. /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed. /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed. and it seems that it is right. Beyond manually inspecting the source files I also did a few build tests with various configs to confirm that including the header in those files is indeed not needed. Here's a patch to remove the pointless includes. Signed-off-by: Jesper Juhl Acked-by: Jozsef Kadlecsik --- net/caif/caif_dev.c | 1 - net/caif/chnl_net.c | 1 - net/ipv4/gre.c | 1 - net/netfilter/ipset/ip_set_core.c | 1 - net/netfilter/xt_set.c | 1 - 5 files changed, 0 insertions(+), 5 deletions(-) diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index 682c0fe..7c2fa0a 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c @@ -11,7 +11,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ -#include #include #include #include diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index adbb424..8237766 100644 --- a/net/caif/chnl_net.c +++ b/net/caif/chnl_net.c @@ -7,7 +7,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ -#include #include #include #include diff --git a/net/ipv4/gre.c b/net/ipv4/gre.c index c6933f2..9dbe108 100644 --- a/net/ipv4/gre.c +++ b/net/ipv4/gre.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 42aa64b..40c9645 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include diff --git a/net/netfilter/xt_set.c b/net/netfilter/xt_set.c index b3babae..5c23c44 100644 --- a/net/netfilter/xt_set.c +++ b/net/netfilter/xt_set.c @@ -13,7 +13,6 @@ #include #include -#include #include #include