From patchwork Sat Jun 11 16:36:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 100023 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5C191B706A for ; Sun, 12 Jun 2011 02:45:38 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817Ab1FKQpG (ORCPT ); Sat, 11 Jun 2011 12:45:06 -0400 Received: from swampdragon.chaosbits.net ([90.184.90.115]:10964 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254Ab1FKQpF (ORCPT ); Sat, 11 Jun 2011 12:45:05 -0400 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id C07319403D; Sat, 11 Jun 2011 18:36:42 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id B9D9F9403B; Sat, 11 Jun 2011 18:36:42 +0200 (CEST) Date: Sat, 11 Jun 2011 18:36:42 +0200 (CEST) From: Jesper Juhl To: Karsten Keil cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Sprenger , Martin Bachem Subject: [PATCH] ISDN, hfcsusb: Don't leak in hfcsusb_ph_info() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We leak the memory allocated to 'phi' when the variable goes out of scope in hfcsusb_ph_info(). Signed-off-by: Jesper Juhl --- hfcsusb.c | 1 + 1 file changed, 1 insertion(+) I have no way to really test this patch, so it is only compile tested. diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c index 3ccbff1..71a8eb6 100644 --- a/drivers/isdn/hardware/mISDN/hfcsusb.c +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c @@ -283,6 +283,7 @@ hfcsusb_ph_info(struct hfcsusb *hw) _queue_data(&dch->dev.D, MPH_INFORMATION_IND, MISDN_ID_ANY, sizeof(struct ph_info_dch) + dch->dev.nrbchan * sizeof(struct ph_info_ch), phi, GFP_ATOMIC); + kfree(phi); } /*