From patchwork Sat Feb 5 20:41:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 82019 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F3855B711E for ; Sun, 6 Feb 2011 07:43:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438Ab1BEUmh (ORCPT ); Sat, 5 Feb 2011 15:42:37 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:29551 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349Ab1BEUmg (ORCPT ); Sat, 5 Feb 2011 15:42:36 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 20E229403D; Sat, 5 Feb 2011 21:41:53 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 1A6049403B; Sat, 5 Feb 2011 21:41:53 +0100 (CET) Date: Sat, 5 Feb 2011 21:41:53 +0100 (CET) From: Jesper Juhl To: Daniele Venzano cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] sis900: Fix mem leak in sis900_rx error path Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix memory leak in error path of sis900_rx(). If we don't do this we'll leak the skb we dev_alloc_skb()'ed just a few lines above when the variable goes out of scope. Signed-off-by: Jesper Juhl --- sis900.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c index 5976d1d..640e368 100644 --- a/drivers/net/sis900.c +++ b/drivers/net/sis900.c @@ -1777,6 +1777,7 @@ static int sis900_rx(struct net_device *net_dev) "cur_rx:%4.4d, dirty_rx:%4.4d\n", net_dev->name, sis_priv->cur_rx, sis_priv->dirty_rx); + dev_kfree_skb(skb); break; }