| Message ID | alpine.LNX.2.00.1102032224110.1369@swampdragon.chaosbits.net |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index 0c7811f..ec4a21d 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1786,6 +1786,8 @@ int be_cmd_get_seeprom_data(struct be_adapter *adapter, spin_lock_bh(&adapter->mcc_lock); wrb = wrb_from_mccq(adapter); + if (!wrb) + return -EBUSY; req = nonemb_cmd->va; sge = nonembedded_sgl(wrb);
wrb_from_mccq() may return null, so we may crash on a null deref in be_cmd_get_seeprom_data(). This avoids that potential crash. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- be_cmds.c | 2 ++ 1 file changed, 2 insertions(+)