From patchwork Sun Jan 23 22:19:55 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 80080 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EC7CB1007D2 for ; Mon, 24 Jan 2011 09:20:04 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711Ab1AWWTd (ORCPT ); Sun, 23 Jan 2011 17:19:33 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:19965 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248Ab1AWWTS (ORCPT ); Sun, 23 Jan 2011 17:19:18 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 5A58F94051; Sun, 23 Jan 2011 23:19:55 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 5350E94040; Sun, 23 Jan 2011 23:19:55 +0100 (CET) Date: Sun, 23 Jan 2011 23:19:55 +0100 (CET) From: Jesper Juhl To: linux-usb@vger.kernel.org cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Greg Kroah-Hartman , The Zapman , Michael Rothwell Subject: [PATCH] USB NET KL5KUSB101: Fix mem leak in error path of kaweth_download_firmware() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We will leak the storage allocated by request_firmware() if the size of the firmware is greater than KAWETH_FIRMWARE_BUF_SIZE. This removes the leak by calling release_firmware() before we return -ENOSPC. Signed-off-by: Jesper Juhl --- kaweth.c | 1 + 1 file changed, 1 insertion(+) Compile tested only since I do not have the hardware. diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index 5e98643..7dc8497 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -406,6 +406,7 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth, if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) { err("Firmware too big: %zu", fw->size); + release_firmware(fw); return -ENOSPC; } data_len = fw->size;