From patchwork Mon Jan 10 23:47:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 78263 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 98A8DB70B3 for ; Tue, 11 Jan 2011 10:48:21 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678Ab1AJXrq (ORCPT ); Mon, 10 Jan 2011 18:47:46 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:17058 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292Ab1AJXrq (ORCPT ); Mon, 10 Jan 2011 18:47:46 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id E5F5A9403D; Tue, 11 Jan 2011 00:47:44 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id E34C49403B; Tue, 11 Jan 2011 00:47:44 +0100 (CET) Date: Tue, 11 Jan 2011 00:47:44 +0100 (CET) From: Jesper Juhl To: linux-wireless@vger.kernel.org cc: users@rt2x00.serialmonkey.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Gertjan van Wingerde , "John W. Linville" , Ivo van Doorn Subject: [PATCH] rt2x00: Don't leak mem in error path of rt2x00lib_request_firmware() Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We need to release_firmware() in order not to leak memory. Signed-off-by: Jesper Juhl Acked-by: Ivo van Doorn Acked-by: Pekka Enberg --- rt2x00firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/rt2x00/rt2x00firmware.c b/drivers/net/wireless/rt2x00/rt2x00firmware.c index f0e1eb7..be0ff78 100644 --- a/drivers/net/wireless/rt2x00/rt2x00firmware.c +++ b/drivers/net/wireless/rt2x00/rt2x00firmware.c @@ -58,6 +58,7 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev) if (!fw || !fw->size || !fw->data) { ERROR(rt2x00dev, "Failed to read Firmware.\n"); + release_firmware(fw); return -ENOENT; }