From patchwork Sat Dec 25 18:17:02 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Juhl X-Patchwork-Id: 76696 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 636CDB70A3 for ; Sun, 26 Dec 2010 05:27:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258Ab0LYS0s (ORCPT ); Sat, 25 Dec 2010 13:26:48 -0500 Received: from swampdragon.chaosbits.net ([90.184.90.115]:14468 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831Ab0LYS0r (ORCPT ); Sat, 25 Dec 2010 13:26:47 -0500 Received: by swampdragon.chaosbits.net (Postfix, from userid 1000) id 645399403D; Sat, 25 Dec 2010 19:17:02 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by swampdragon.chaosbits.net (Postfix) with ESMTP id 5D7419403B; Sat, 25 Dec 2010 19:17:02 +0100 (CET) Date: Sat, 25 Dec 2010 19:17:02 +0100 (CET) From: Jesper Juhl To: ceph-devel@vger.kernel.org cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Sage Weil , "David S. Miller" Subject: [PATCH] Ceph: Fix a use-after-free bug in ceph_destroy_client(). Message-ID: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, In net/ceph/ceph_common.c::ceph_destroy_client() the pointer 'client' is freed by kfree() and subsequently used in a call to dout() - use after free bug. Easily fixed by simply moving the kfree() call after the dout() call. Signed-off-by: Jesper Juhl --- ceph_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c index f3e4a13..890bbbf 100644 --- a/net/ceph/ceph_common.c +++ b/net/ceph/ceph_common.c @@ -408,8 +408,8 @@ void ceph_destroy_client(struct ceph_client *client) ceph_destroy_options(client->options); - kfree(client); dout("destroy_client %p done\n", client); + kfree(client); } EXPORT_SYMBOL(ceph_destroy_client);