diff mbox series

[v2] net: macb: change GFP_KERNEL to GFP_ATOMIC

Message ID alpine.DEB.2.20.1712020800010.2168@hadrien
State Accepted, archived
Delegated to: David Miller
Headers show
Series [v2] net: macb: change GFP_KERNEL to GFP_ATOMIC | expand

Commit Message

Julia Lawall Dec. 2, 2017, 7:01 a.m. UTC
Function gem_add_flow_filter called on line 2958 inside lock on line 2949
but uses GFP_KERNEL

Generated by: scripts/coccinelle/locks/call_kern.cocci

Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering")
CC: Rafal Ozieblo <rafalo@cadence.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

v2: Fix some broken email addresses.  No change to the patch.

tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head:   fb20eb9d798d2f4c1a75b7fe981d72dfa8d7270d
commit: ae8223de3df5a0ce651d14a50dad31b9cae029f2 [2033/2251] net: macb:
Added support for RX filtering

 macb_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Dec. 5, 2017, 4:27 p.m. UTC | #1
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Sat, 2 Dec 2017 08:01:21 +0100 (CET)

> Function gem_add_flow_filter called on line 2958 inside lock on line 2949
> but uses GFP_KERNEL
> 
> Generated by: scripts/coccinelle/locks/call_kern.cocci
> 
> Fixes: ae8223de3df5 ("net: macb: Added support for RX filtering")
> CC: Rafal Ozieblo <rafalo@cadence.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied to net-next.
diff mbox series

Patch

--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -2799,7 +2799,7 @@  static int gem_add_flow_filter(struct ne
 	int ret = -EINVAL;
 	bool added = false;

-	newfs = kmalloc(sizeof(*newfs), GFP_KERNEL);
+	newfs = kmalloc(sizeof(*newfs), GFP_ATOMIC);
 	if (newfs == NULL)
 		return -ENOMEM;
 	memcpy(&newfs->fs, fs, sizeof(newfs->fs));