From patchwork Sat May 27 04:38:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 767661 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wZVdC5m9tz9s7v for ; Sat, 27 May 2017 14:38:55 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751745AbdE0EiT (ORCPT ); Sat, 27 May 2017 00:38:19 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:24873 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdE0EiR (ORCPT ); Sat, 27 May 2017 00:38:17 -0400 X-IronPort-AV: E=Sophos;i="5.38,400,1491256800"; d="scan'208";a="225855957" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 May 2017 06:38:15 +0200 Date: Sat, 27 May 2017 06:38:14 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Andrew Lunn cc: netdev@vger.kernel.org, Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] dsa: mv88e6xxx: fix returnvar.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrew Lunn Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- It's a minor issue, but since there is no error, the code is a bit misleading. tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 47936d35edbac5e58064bd15e51136050b2f2717 commit: 04aca9938255fc7097b3fb5700f408524656f2e2 [330/362] dsa: mv88e6xxx: Enable/Disable SERDES on port enable/disable chip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -1982,13 +1982,12 @@ static int mv88e6xxx_port_enable(struct struct phy_device *phydev) { struct mv88e6xxx_chip *chip = ds->priv; - int err = 0; mutex_lock(&chip->reg_lock); mv88e6xxx_serdes_power(chip, port, true); mutex_unlock(&chip->reg_lock); - return err; + return 0; } static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port,