From patchwork Tue Jun 21 10:03:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 638604 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rYjz12zkmz9snk for ; Tue, 21 Jun 2016 20:05:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbcFUKDj (ORCPT ); Tue, 21 Jun 2016 06:03:39 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:31594 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcFUKDg (ORCPT ); Tue, 21 Jun 2016 06:03:36 -0400 X-IronPort-AV: E=Sophos;i="5.26,503,1459807200"; d="scan'208";a="181973937" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Jun 2016 12:03:33 +0200 Date: Tue, 21 Jun 2016 12:03:28 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: thloh@altera.com cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, davem@davemloft.net, preid@electromag.com.au, dinguyen@opensource.altera.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thloh85@gmail.com, cnphoon@altera.com, thloh@altera.com, kbuild-all@01.org Subject: [PATCH] net: ethernet: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Tien Hock Loh Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- This patch refers to the following code: url: https://github.com/0day-ci/linux/commits/thloh-altera-com/net-ethernet-Add-T SE-PCS-support-to-dwmac-socfpga/20160621-164854 dwmac-socfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c @@ -224,7 +224,7 @@ static int socfpga_dwmac_parse_data(stru dev_err(dev, "%s: ERROR: failed mapping tse control port\n", __func__); - return PTR_ERR(dwmac->pcs.sgmii_adapter_base); + return PTR_ERR(dwmac->pcs.tse_pcs_base); } } }