From patchwork Wed Jun 8 16:15:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 632370 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rPtpG5lKgz9sdb for ; Thu, 9 Jun 2016 02:15:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756906AbcFHQPg (ORCPT ); Wed, 8 Jun 2016 12:15:36 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:6749 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753850AbcFHQPe (ORCPT ); Wed, 8 Jun 2016 12:15:34 -0400 X-IronPort-AV: E=Sophos;i="5.26,439,1459807200"; d="scan'208";a="221664794" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Jun 2016 18:15:31 +0200 Date: Wed, 8 Jun 2016 18:15:29 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Mike Rapoport cc: "Michael S. Tsirkin" , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: [PATCH] macvtap: fix bugon.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use BUG_ON instead of a if condition followed by BUG. Generated by: scripts/coccinelle/misc/bugon.cocci CC: Mike Rapoport Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- macvtap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -796,8 +796,7 @@ static ssize_t macvtap_put_user(struct m ret = virtio_net_hdr_from_skb(skb, &vnet_hdr, macvtap_is_little_endian(q)); - if (ret) - BUG(); + BUG_ON(ret); if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter) != sizeof(vnet_hdr))