diff mbox

i40iw: fix compare_const_fl.cocci warnings

Message ID alpine.DEB.2.02.1512220913040.2057@localhost6.localdomain6
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Julia Lawall Dec. 22, 2015, 8:15 a.m. UTC 
Move constants to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Faisal Latif <faisal.latif@intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

It's a minor point, but when I first looked at the code, I thought that 
MIN and MAX were inverted, so it could be good to change.

 i40iw_ctrl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
@@ -1664,7 +1664,7 @@  static enum i40iw_status_code i40iw_sc_c
 {
 	u32 pble_obj_cnt;
 
-	if (I40IW_MIN_CQ_SIZE > info->num_elem || I40IW_MAX_CQ_SIZE < info->num_elem)
+	if (info->num_elem < I40IW_MIN_CQ_SIZE || info->num_elem > I40IW_MAX_CQ_SIZE)
 		return I40IW_ERR_INVALID_SIZE;
 
 	if (info->ceq_id > I40IW_MAX_CEQID)