From patchwork Wed Dec 20 22:01:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 851705 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X5ePifn4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z27zM6nkBz9t3p for ; Thu, 21 Dec 2017 09:02:07 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757505AbdLTWCF (ORCPT ); Wed, 20 Dec 2017 17:02:05 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33402 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757356AbdLTWBx (ORCPT ); Wed, 20 Dec 2017 17:01:53 -0500 Received: by mail-wm0-f68.google.com with SMTP id g130so17598273wme.0 for ; Wed, 20 Dec 2017 14:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=weJV7HiU8ngHZwZ00iHDKMEU9YwhSFnywbARtq1K/Ck=; b=X5ePifn4AhQX0XGMuC+m9j1XiHUepLKQGkG+epQwK7H0RcDpruNiZpDYDchSfryFR4 QegMhPdWLC46qNFklsGVt0vDktC/HyUeMEAcAIYfW0kuJNnxABXQZno+bjKtwHnqtxNE z54Ff2jVeUUG7BXPESwyiL/OmUKcFkDoxRlWyk784Dvu8YKpG+KrF2sSMX3fzCfjbyjP 4DJKjRI/p68E/kmpoNXyhF6bRStsdyJY0KFSfB8vdzayn12xvOrC5IsWYd4A1stoQBtl 3C5oUcl3MacpG1B1EmHuQgFwx9HN2Xx5j7NGykUGZvH92xgb0YHOpj8/6Om7JwCdNP70 A31A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=weJV7HiU8ngHZwZ00iHDKMEU9YwhSFnywbARtq1K/Ck=; b=WPY8sRBsyjztv2zbGhySvq86BS9BeE2/k6Mdi5ChiiTIfDWjoYCeEvJQaqlrwicK6r OD9knCkNRePJ6TDXyXO+u+rFW0dIqRvX+6E3aeVbAZv2tisP7yXykkB6oyXIrXB9gCj2 1bDHWTPB7QqphZ+UYB2ELeiNDSTfYQm9xIco3mFIBTPitD9lw6fWX9xbsyrs2OArXI6l RY0Eysi8WDKwY4eEsKFT3cUHZGGpXmoLLlLy8ZTUzWig8iFkGZEkb3lyST93IvC5Q14I 3z+pOgEMXo5LfGkjyxl8r0/r8fhNkcyTJrgUE/Fb3kRPGVp8oJ/9K2sTBFW0D1YsoiLe x8Jw== X-Gm-Message-State: AKGB3mLQwDofrbbcE2FNjRbtXN50Ps3V330hzNWRbXOA9bYNtFMEkFB/ 4M6x/akPhQ86UjFcxEduidKzWxhE X-Google-Smtp-Source: ACJfBosTbLXfO2xQcw7M18Q/QcLZoNNzPfwrQm04mWFf5hWVaqh98/KYqJmH9RVPa/aq3wI26F5Vug== X-Received: by 10.28.51.21 with SMTP id z21mr8190111wmz.94.1513807312033; Wed, 20 Dec 2017 14:01:52 -0800 (PST) Received: from debian64.daheim (p5B0D727A.dip0.t-ipconnect.de. [91.13.114.122]) by smtp.gmail.com with ESMTPSA id t138sm7060332wme.16.2017.12.20.14.01.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Dec 2017 14:01:50 -0800 (PST) Received: from chuck by debian64.daheim with local (Exim 4.90_RC4) (envelope-from ) id 1eRmQw-0005J6-2I; Wed, 20 Dec 2017 23:01:50 +0100 From: Christian Lamparter To: netdev@vger.kernel.org Cc: "David S . Miller" , Andrew Lunn , Christophe Jaillet Subject: [PATCH v3 1/3] net: ibm: emac: replace custom rgmii_mode_name with phy_modes Date: Wed, 20 Dec 2017 23:01:48 +0100 Message-Id: X-Mailer: git-send-email 2.15.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org phy_modes() in the common phy.h already defines the same phy mode names in lower case. The deleted rgmii_mode_name() is used only in one place and for a "notice-level" printk. Hence, it will not be missed. Signed-off-by: Christian Lamparter --- drivers/net/ethernet/ibm/emac/rgmii.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/net/ethernet/ibm/emac/rgmii.c b/drivers/net/ethernet/ibm/emac/rgmii.c index c4a1ac38bba8..9a1c06f2471d 100644 --- a/drivers/net/ethernet/ibm/emac/rgmii.c +++ b/drivers/net/ethernet/ibm/emac/rgmii.c @@ -59,24 +59,6 @@ static inline int rgmii_valid_mode(int phy_mode) phy_mode == PHY_MODE_RTBI; } -static inline const char *rgmii_mode_name(int mode) -{ - switch (mode) { - case PHY_MODE_RGMII: - return "RGMII"; - case PHY_MODE_TBI: - return "TBI"; - case PHY_MODE_GMII: - return "GMII"; - case PHY_MODE_MII: - return "MII"; - case PHY_MODE_RTBI: - return "RTBI"; - default: - BUG(); - } -} - static inline u32 rgmii_mode_mask(int mode, int input) { switch (mode) { @@ -115,7 +97,7 @@ int rgmii_attach(struct platform_device *ofdev, int input, int mode) out_be32(&p->fer, in_be32(&p->fer) | rgmii_mode_mask(mode, input)); printk(KERN_NOTICE "%pOF: input %d in %s mode\n", - ofdev->dev.of_node, input, rgmii_mode_name(mode)); + ofdev->dev.of_node, input, phy_modes(mode)); ++dev->users;