| Message ID | a183bfa67a3c3ca6c62676f01434eb921c9dc008.1544633931.git.jtoppins@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] bnxt: remove printing of hwrm message | expand |
On Wed, Dec 12, 2018 at 8:59 AM Jonathan Toppins <jtoppins@redhat.com> wrote: > > bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm > req_type 0x190 seq id 0x6 error 0xffff > > The message above is commonly seen when a newer driver is used on > hardware with older firmware. The issue is this message means nothing to > anyone except Broadcom. Remove the message to not confuse users as this > message is really not very informative. > > Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> > --- > > Notes: > v2: > include changes recommended by Michael Chan > Acked-by: Michael Chan <michael.chan@broadcom.com>
From: Jonathan Toppins <jtoppins@redhat.com> Date: Wed, 12 Dec 2018 11:58:51 -0500 > bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm > req_type 0x190 seq id 0x6 error 0xffff > > The message above is commonly seen when a newer driver is used on > hardware with older firmware. The issue is this message means nothing to > anyone except Broadcom. Remove the message to not confuse users as this > message is really not very informative. > > Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> > --- > > Notes: > v2: > include changes recommended by Michael Chan Applied, thank you.
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 5d21c14853ac..f4f29939ba72 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -6190,7 +6190,8 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all) req.fid = cpu_to_le16(0xffff); mutex_lock(&bp->hwrm_cmd_lock); - rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); + rc = _hwrm_send_message_silent(bp, &req, sizeof(req), + HWRM_CMD_TIMEOUT); if (rc) { rc = -EIO; goto hwrm_func_resc_qcaps_exit;
bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm req_type 0x190 seq id 0x6 error 0xffff The message above is commonly seen when a newer driver is used on hardware with older firmware. The issue is this message means nothing to anyone except Broadcom. Remove the message to not confuse users as this message is really not very informative. Signed-off-by: Jonathan Toppins <jtoppins@redhat.com> --- Notes: v2: include changes recommended by Michael Chan drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)