| Message ID | E1jx73g-0006mp-UI@rmk-PC.armlinux.org.uk |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] arm64: dts: clearfog-gt-8k: fix switch link configuration | expand |
On Sun, Jul 19, 2020 at 12:00:40PM +0100, Russell King wrote: > The commit below caused a regression for clearfog-gt-8k, where the link > between the switch and the host does not come up. > > Investigation revealed two issues: > - MV88E6xxx DSA no longer allows an in-band link to come up as the link > is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix > in-band AN link establishment" addresses this. > > - The dts configured dissimilar link modes at each end of the host to > switch link; the host was configured using a fixed link (so has no > in-band status) and the switch was configured to expect in-band > status. > > With both issues fixed, the regression is resolved. > > Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link") > Reported-by: Martin Rowe <martin.p.rowe@gmail.com> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: Russell King <rmk+kernel@armlinux.org.uk> Date: Sun, 19 Jul 2020 12:00:40 +0100 > The commit below caused a regression for clearfog-gt-8k, where the link > between the switch and the host does not come up. > > Investigation revealed two issues: > - MV88E6xxx DSA no longer allows an in-band link to come up as the link > is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix > in-band AN link establishment" addresses this. > > - The dts configured dissimilar link modes at each end of the host to > switch link; the host was configured using a fixed link (so has no > in-band status) and the switch was configured to expect in-band > status. > > With both issues fixed, the regression is resolved. > > Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link") > Reported-by: Martin Rowe <martin.p.rowe@gmail.com> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Applied and queued up for -stable, thanks.
diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts index c8243da71041..eb01cc96ba7a 100644 --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts @@ -454,10 +454,7 @@ status = "okay"; phy-mode = "2500base-x"; phys = <&cp1_comphy5 2>; - fixed-link { - speed = <2500>; - full-duplex; - }; + managed = "in-band-status"; }; &cp1_spi1 {
The commit below caused a regression for clearfog-gt-8k, where the link between the switch and the host does not come up. Investigation revealed two issues: - MV88E6xxx DSA no longer allows an in-band link to come up as the link is programmed to be forced down. Commit "net: dsa: mv88e6xxx: fix in-band AN link establishment" addresses this. - The dts configured dissimilar link modes at each end of the host to switch link; the host was configured using a fixed link (so has no in-band status) and the switch was configured to expect in-band status. With both issues fixed, the regression is resolved. Fixes: 34b5e6a33c1a ("net: dsa: mv88e6xxx: Configure MAC when using fixed link") Reported-by: Martin Rowe <martin.p.rowe@gmail.com> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)