From patchwork Wed Apr 12 16:26:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 750066 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w38Sr2rqWz9s8C for ; Thu, 13 Apr 2017 02:26:52 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pHuWTqMa"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754970AbdDLQ0u (ORCPT ); Wed, 12 Apr 2017 12:26:50 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34928 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755011AbdDLQ0p (ORCPT ); Wed, 12 Apr 2017 12:26:45 -0400 Received: by mail-oi0-f45.google.com with SMTP id f22so37992199oib.2 for ; Wed, 12 Apr 2017 09:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ospjr0tA6SmSOVuu+SDwtgHxiCYwBvU5We97hdwUAZk=; b=pHuWTqMaWR6mKCzPuXVBtC00jEBHNOu+v/DCch+3dFE/nY0RhYQ7KHE5XqCR0hiDBC MW6Ka7wvZq8epjhVn2dYo/5aUdkzb/6mCsW0YgZYVkO/KkJtYOOd2RB+11Qb7mDa2c3W 8rlwWXfMviuXNkwDRJOWiMxwdSUd8BKIsfh7hoyPd73KQOzh/vq75N3t5+rF0RKjAueN eiMrFPJxABS/LhY7mSQSocpeCMkHztyff3mYMdcBw//dcRULzwmOh5VtN2YjTCX+B33I P8f1w+JN/zE1pPSgyd9NQ0hmTnkyeWOChNdYfG9Abgu/ogvlWf3AOHMrLse4rGDfCerU YOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ospjr0tA6SmSOVuu+SDwtgHxiCYwBvU5We97hdwUAZk=; b=o1cPx73r2j33/aeg30MFVMLc/Ox3E48DOPQizqhSEvwx89L0JZVFz3lWXiA9ddJmZY EDsl2KefdhqDDb4j4ia6fIBT/J+D/ptpqIjTc7C7Q11BCJgXJcVS+3mpmlYwFWq9+tmE UMw800xC4/rRra8+p5Mr+yR8hGwxRqc0jFOT2WdVkMK1vHhOBOA4mK17UFMc7vJwv5jz tj1IQc5HsiKdb9+oVzR8ja72CCV/2Op3lJ9dmaYTqovd+dJATYlOluSVcxviILi0Dsab VYIHAoEWglj9EtjL0GM4ouh+siVqgkkkXpymW+Pj9xuR5/N4+31fSeJiow8D33/xZdmy p2GQ== X-Gm-Message-State: AN3rC/7u9TqWSM00fbxlJGk6PrRpnVp8GjSpAtn+Yj7uK6hSIx5WXPhH1Uc+DjmqjBBgG7Imh1eTSB1B/m0/SQ== X-Received: by 10.157.6.7 with SMTP id 7mr7448otn.219.1492014399429; Wed, 12 Apr 2017 09:26:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.43.176 with HTTP; Wed, 12 Apr 2017 09:26:39 -0700 (PDT) In-Reply-To: References: <20170407160915.GF23415@lunn.ch> From: Fabio Estevam Date: Wed, 12 Apr 2017 13:26:39 -0300 Message-ID: Subject: Re: IMX6 FEC connection drops occasionally with 'MDIO read timeout' To: Tim Harvey Cc: Andrew Lunn , netdev , Fabio Estevam , Lucas Stach , Fugang Duan , Koen Vandeputte Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Tim, On Wed, Apr 12, 2017 at 1:15 PM, Tim Harvey wrote: > > Andrew, > > Thanks for the reply. Your talking about suspend/resume power > management right? The users reporting this were not using > suspend/resume. > > With regards to clock are you talking about the IPG clock? Is there > any other way that would get turned off other than fec suspend/resume? Yes, through pm_runtime. Can you check if this quick debug change help? If you don't see the problem with it, then it means we need to fix the pm runtime support in this driver. Most likely pm runtime is turning off the clocks when it should not. --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3606,8 +3606,6 @@ static int __maybe_unused fec_runtime_suspend(struct device *dev) struct net_device *ndev = dev_get_drvdata(dev); struct fec_enet_private *fep = netdev_priv(ndev); - clk_disable_unprepare(fep->clk_ipg); - return 0; }