From patchwork Wed Feb 8 14:47:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 725648 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vJPGg1mRQz9s7Z for ; Thu, 9 Feb 2017 01:48:42 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="C7y1qL82"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbdBHOsh (ORCPT ); Wed, 8 Feb 2017 09:48:37 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34766 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700AbdBHOsf (ORCPT ); Wed, 8 Feb 2017 09:48:35 -0500 Received: by mail-oi0-f45.google.com with SMTP id s203so83028407oie.1 for ; Wed, 08 Feb 2017 06:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tHTugbx5GLz/yjuNLSzVLfTHqlqTUgs7xrkuuA8p+Bs=; b=C7y1qL82akY6V8hz0ttC6/cyCKT9HYcwDeXO4zamtiROLY7Lgvz+LW0/ezm1u5PCkf pGt3ScwOpjj4LrYnjCnr3leQIc7oFDhCxQ8gKrX/APLgFrRKKM644BDj0Vnwl1b3VdwP Q84YcFl3iJ90/MhFNz4CB4gcp9dKTbHjyAGOe9UkodiQ4svH6NGCK1c7iMPT+Og3Gyzp kDtQXrobLdLvol5LkHwoy3joBqjQJIss7YmfrOogTcaC5m0/cJO7FxbEj8T8cTrFhzlX 7/D5c0w/cq9npv1++DFE7uLDWbKo0VT0lYMrdcLDT3ctq9zS0XqVOo9Jso3CBx4GHs/e krJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tHTugbx5GLz/yjuNLSzVLfTHqlqTUgs7xrkuuA8p+Bs=; b=DETJv9yOXJ5Ma3jGV0pwKmh4KjJ/LShFZ9Kdm8MX8LFB1DjihF2sp3sSVZe5nVDkXM hg7iTgpKSCMG/RXtiZqhkAujsjlcBdeRzAVwswQR2NNhH2A2H+Aqcy/A2YMseKw1wJ9t hfK63Zq4nk221nytZMH1wU9OuJCJ1KJggJt5ZVZ322M9a8kz9GNaUyU3J/mHONyLLjsU /PWoGjUXW18vIuh8NwLk4VTZzTViH+iV2Po8kxW1U86bBKPJLwlh7rIrut9JLT2k3Lhq vTqmaOU63KsSqbkRfbpvBN215yvAjKQzqcU0v112X5KbZh55PUw+Zqg+k8tQtR3auJSW Y+8A== X-Gm-Message-State: AMke39mYd0RaOQbHqxkv57LPjx/QxUAZsHRUvQn64tiT2uJRZ10zcrB9CI/Dods3aea3eJT2U35VPuJbCQiRAA== X-Received: by 10.202.193.65 with SMTP id r62mr11156485oif.90.1486565267940; Wed, 08 Feb 2017 06:47:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.47.217 with HTTP; Wed, 8 Feb 2017 06:47:47 -0800 (PST) In-Reply-To: <20170208144029.GE10855@lunn.ch> References: <20170208142857.GD10855@lunn.ch> <20170208144029.GE10855@lunn.ch> From: Fabio Estevam Date: Wed, 8 Feb 2017 12:47:47 -0200 Message-ID: Subject: Re: Kernel crashes in phy_attach_direct() To: Andrew Lunn Cc: Florian Fainelli , "netdev@vger.kernel.org" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 8, 2017 at 12:40 PM, Andrew Lunn wrote: > And i guess you don't have a specific PHY driver for you PHYs. You are > using the generic PHY driver? Yes, I am: Generic PHY 63fec000.ethernet-1:00: attached PHY driver [Generic PHY] (mii_bus:phy_addr=63fec000.ethernet-1:00, irq=-1) > > Could you try modifying phy_attach_direct() such that the > try_module_get() is after: > > /* Assume that if there is no driver, that it doesn't > * exist, and we should use the genphy driver. > */ > if (!d->driver) { > > } Yes, this is what I am using right now: /* Assume that if there is no driver, that it doesn't @@ -946,6 +941,11 @@ int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, goto error; } + if (!try_module_get(d->driver->owner)) { + dev_err(&dev->dev, "failed to get the device driver module\n"); + return -EIO; + } + if (phydev->attached_dev) { dev_err(&dev->dev, "PHY already attached\n"); err = -EBUSY; Would you like me to submit this one? Thanks --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -920,11 +920,6 @@ int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, return -EIO; } - if (!try_module_get(d->driver->owner)) { - dev_err(&dev->dev, "failed to get the device driver module\n"); - return -EIO; - } - get_device(d);