From patchwork Mon Sep 26 21:00:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 675328 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sjbwK6ljsz9s65 for ; Tue, 27 Sep 2016 07:00:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=QkBC3Aie; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035096AbcIZVAj (ORCPT ); Mon, 26 Sep 2016 17:00:39 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:35417 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034924AbcIZVAf (ORCPT ); Mon, 26 Sep 2016 17:00:35 -0400 Received: by mail-vk0-f67.google.com with SMTP id 192so3452960vkl.2 for ; Mon, 26 Sep 2016 14:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1TRGW+e3RtNrRSHl1abgaJNQrw/MYRp/51eHn7p98sY=; b=QkBC3AieSt6UIY9P+qlXyZ/Urez+wylqKV3vGLIt8QkjFvNSMLbWeiUj4AhywIgGKI B0NU/zAH4wJnRpwEfTsDuW3l2gByYnKnF/h/VMFuk/1Vqkp1sj1Jx4Z1VWK0vJbnoEN2 8/DpcBLBAfy+Ln/I4DB+3XMQLhEggK3LCc+1oWKW7cc8SgY/7PW2mRHYSi5Wu7s6K0w5 cIVhk/4r6/sakTo4D7w82Wf/Fb8F3MEZMALPBUAPOcgClX2vn+mjbESKvJ0EicWt48Nr 67nX2byNvV+hkX1x8hfXKFk/+zjVZ6DMG6if0GLbL+AdZ21C8bgz7MmEXERLsg0yfYwk L2ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1TRGW+e3RtNrRSHl1abgaJNQrw/MYRp/51eHn7p98sY=; b=NcNRC5OMRmSoHe9aPf+0KSwE9GbZD70HScMQQVwRiqBxyk99Rm/xjkeuWgKYeuZCHn bZv+BpVy28Rc5OSl8Xpu48hKzfbLoT8eU3UDpsM5QvvHBYOKSCNS4fC0am0B1yMao/Eh B/RF+/Obg8EVmYd9YDYccn922Pwh3K3XFrCZnT/6/kwvzHZlPs11OMTkKBLJkM6bkWSX 4TWKOuuMgkcsKsXR9puRF6YqV7Kxbh4XCOvlwJpcEE9Dk2wGJbBe97hpdaJp8UW5dr/R he/kshJqz+ugz8KqXLvXquRJ+4/E0jqA/KSg+LlHWGUfTchY1VoeB8yJp3Rcr4FIr7IO WrAQ== X-Gm-Message-State: AA6/9RlMcXAgy78Y2rw+rUAusByMDCqKY9mmV8+YHXGLS9vbKpGrGtDHm4b0GeqKTnwVGedXn6ZyVgnPF/LgNQ== X-Received: by 10.31.9.212 with SMTP id 203mr8713082vkj.99.1474923632869; Mon, 26 Sep 2016 14:00:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.27.216 with HTTP; Mon, 26 Sep 2016 14:00:32 -0700 (PDT) In-Reply-To: <20160926191140.12107-1-albert.aribaud@3adev.fr> References: <20160926191140.12107-1-albert.aribaud@3adev.fr> From: Fabio Estevam Date: Mon, 26 Sep 2016 18:00:32 -0300 Message-ID: Subject: Re: [PATCH] net: trivial: fix fsl fec_main mdio write return value To: "Albert ARIBAUD (3ADEV)" Cc: "netdev@vger.kernel.org" , Jiri Kosina , Fugang Duan Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Albert, On Mon, Sep 26, 2016 at 4:11 PM, Albert ARIBAUD (3ADEV) wrote: > If the MDIO enf-of-transfer wait loop does not time out, > 0 should be returned to the caller through ret, but ret > was not reset to 0 after receiving the return value of > pm_runtime_get_sync(). Reset ret when no time out occurred.Is this really needed? Commit 42ea4457 ("net: fec: normalize return value of pm_runtime_get_sync() in MDIO write") does the following: > index 01f7e81..0413c05 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -1818,6 +1818,8 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, > netdev_err(fep->netdev, "MDIO write timeout\n"); > ret = -ETIMEDOUT; > } > + else > + ret = 0; , so is this really needed? ret should be 0 at this point. diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 91925e3..6cc3340 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1816,11 +1816,13 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, struct fec_enet_private *fep = bus->priv; struct device *dev = &fep->pdev->dev; unsigned long time_left; - int ret = 0; + int ret; ret = pm_runtime_get_sync(dev); if (ret < 0) return ret; + else + ret = 0; > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c