From patchwork Fri Feb 3 03:17:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 139282 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3DFD6B6FA1 for ; Fri, 3 Feb 2012 14:17:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755467Ab2BCDR0 (ORCPT ); Thu, 2 Feb 2012 22:17:26 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:46518 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754747Ab2BCDRY (ORCPT ); Thu, 2 Feb 2012 22:17:24 -0500 Received: by eaah12 with SMTP id h12so1279571eaa.19 for ; Thu, 02 Feb 2012 19:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=YTvmttCVUU3naL+Krz9BFB4YXoV7G2+isKY12jhkBEk=; b=J1tPYy+Z87QlQE+PfhgSJG69e9Qn1/SyiKDzI1DaXvFFIP+DlBCO8is8luL9lKFUaN bf2BVS4wIBSV75If3K500V20jZ9/6OS/2V983WW9cvjIgVEivC8xDM5trbk661AUStBZ DMVq00BSmYJVZ/VmLslXbUW428bFEcIVYJnkQ= MIME-Version: 1.0 Received: by 10.213.4.206 with SMTP id 14mr912653ebs.96.1328239043396; Thu, 02 Feb 2012 19:17:23 -0800 (PST) Received: by 10.213.20.144 with HTTP; Thu, 2 Feb 2012 19:17:23 -0800 (PST) In-Reply-To: References: Date: Fri, 3 Feb 2012 01:17:23 -0200 Message-ID: Subject: Re: Regulator support for smsc911x From: Fabio Estevam To: robert.marklund@stericsson.com Cc: netdev@vger.kernel.org, Sascha Hauer , Mark Brown Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 2, 2012 at 11:02 PM, Fabio Estevam wrote: > Robert, > > Since commit c7e963f6 (net/smsc911x: Add regulator support) I am no > longer able to use smsc911x driver due to the lack of regulators for > smsc on mx31_3ds board. > > Do you a board example that uses such regulator, so that I can look > for a reference? Ok, I fixed it by enabling CONFIG_REGULATOR_DUMMY on imx_v6_v7_defconfig, but I am wondering if the patch below would be a more appropriate fix: Please advise if I should fix it in Kconfig or defconfig, so that I can submit a patch. Regards, Fabio Estevam --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/smsc/Kconfig +++ b/drivers/net/ethernet/smsc/Kconfig @@ -102,6 +102,8 @@ config SMSC911X select NET_CORE select MII select PHYLIB + select REGULATOR + select REGULATOR_DUMMY ---help--- Say Y here if you want support for SMSC LAN911x and LAN921x families of ethernet controllers.