From patchwork Wed Mar 20 18:06:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 229445 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E2762C00A7 for ; Thu, 21 Mar 2013 05:06:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586Ab3CTSGZ (ORCPT ); Wed, 20 Mar 2013 14:06:25 -0400 Received: from mail-vc0-f182.google.com ([209.85.220.182]:48038 "EHLO mail-vc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051Ab3CTSGY convert rfc822-to-8bit (ORCPT ); Wed, 20 Mar 2013 14:06:24 -0400 Received: by mail-vc0-f182.google.com with SMTP id ht11so1592544vcb.27 for ; Wed, 20 Mar 2013 11:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=8+i+fnHdMtuv33hPwcOnkl/Y6jUrZSxMfASpma0rumk=; b=wYGChRb90k2Jyy2YIhpn3/vI7adUDkaah+Iay4m6Yy8UFbTdlGai62GfaWGnxSmeIE bhJdm6adqck/VzN7Th6W6CFsiYagouKCLrLdAgvPAM2T7xwTJQfzCfptIzc3ByhyvAOS 8WYY7gdZJEwDu8NJWtnrcUJ9ORdeVO1zVQoEs7BfCGOM4ns6jTxigiU61qCitmMyT20I ivkPt7s9DxEECjB9f4lKtBao36dGmA5pOb5OOxDVEzNd0xqVb8osGVyLSuh2PJt+2dO8 n1pddGzpU4TJIgBgk2K+v9XznEZ2ko7zmFykrijJRQC57aHtbzGPJCZWpcqwTcBgVRL6 kKfw== MIME-Version: 1.0 X-Received: by 10.221.0.199 with SMTP id nn7mr9358887vcb.14.1363802783976; Wed, 20 Mar 2013 11:06:23 -0700 (PDT) Received: by 10.59.5.201 with HTTP; Wed, 20 Mar 2013 11:06:23 -0700 (PDT) In-Reply-To: <20130320160418.GG20530@pengutronix.de> References: <1357265063-30528-1-git-send-email-Frank.Li@freescale.com> <20130320160418.GG20530@pengutronix.de> Date: Wed, 20 Mar 2013 15:06:23 -0300 Message-ID: Subject: Re: [PATCH v3 1/1 net-next] NET: FEC: dynamtic check DMA desc buff type From: Fabio Estevam To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Frank Li , lznuaa@gmail.com, davem@davemloft.net, s.hauer@pengutronix.de, netdev@vger.kernel.org, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Mar 20, 2013 at 1:04 PM, Uwe Kleine-König wrote: > Hello, > > On Fri, Jan 04, 2013 at 10:04:23AM +0800, Frank Li wrote: >> MX6 and mx28 support enhanced DMA descriptor buff to support 1588 >> ptp. But MX25, MX3x, MX5x can't support enhanced DMA descriptor buff. >> Check fec type and choose correct DMA descriptor buff type. >> >> Remove static config CONFIG_FEC_PTP. >> ptp function will be auto detected. > Your patch (now as ff43da86c69d76a726ffe7d1666148960dc1d108 in v3.9-rc1) > breaks building with CONFIG_FEC=m: > > ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined! What about this fix? --- drivers/net/ethernet/freescale/fec_ptp.c | 3 +++ 1 file changed, 3 insertions(+) * fec_time_keep - call timecounter_read every second to avoid timer overrun @@ -383,3 +385,4 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev) pr_info("registered PHC device on %s\n", ndev->name); } } +EXPORT_SYMBOL(fec_ptp_init); diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 1f17ca0..0d8df40 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -128,6 +128,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev) spin_unlock_irqrestore(&fep->tmreg_lock, flags); } +EXPORT_SYMBOL(fec_ptp_start_cyclecounter); /** * fec_ptp_adjfreq - adjust ptp cycle frequency @@ -318,6 +319,7 @@ int fec_ptp_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd) return copy_to_user(ifr->ifr_data, &config, sizeof(config)) ? -EFAULT : 0; } +EXPORT_SYMBOL(fec_ptp_ioctl); /**