From patchwork Wed Mar 30 18:37:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 603560 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qZxFr5mmSz9sCj for ; Thu, 31 Mar 2016 05:37:20 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=nuT4vypP; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754178AbcC3ShS (ORCPT ); Wed, 30 Mar 2016 14:37:18 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:36638 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbcC3ShQ (ORCPT ); Wed, 30 Mar 2016 14:37:16 -0400 Received: by mail-io0-f179.google.com with SMTP id q128so83333561iof.3 for ; Wed, 30 Mar 2016 11:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=+uwhcE14u44x9OKpHUmMRUPxa+Nm3YvKypzlF57WBIY=; b=nuT4vypPEUJd0mXf62dU/cS/Bj4xebzn8c6JmUXKEEQF8Klk7wxhYAtUFnOiiUASNn ZbdGXAWiETQgFjoFmBMYjYJzHGpbyJrQtU8EAVLl6y07QWD9r1isfiGtce5PHFtuXpr7 208WnPoA1HwI/Xv+Ht1VXCsyvju/3+8NhBLaA5+v6Y6cWNgfRLzOy04XTcnkansTd37m MDW3y6LxWGFHUrAv+xvoR5DO7w8HLWVGGbSEoLvOPP98z2zBqXH5aoO9hugqFNyBnwPc RfOtTCWDatlmQt+PyplkEClUvUBSn7lc1ba0UfaGPqqlUewrQYfPxpVIVg4TV7A1Uvob wxfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=+uwhcE14u44x9OKpHUmMRUPxa+Nm3YvKypzlF57WBIY=; b=kPi4WYCLRZmd0TKhFbkVDtkNvLAjjBdnHZCiTPm+Esm7oom1Z7fJ1uZrHOi3Q4ip4B N1l+pFnh8AQA7YNV6qQuSumTBhkAr2BJRIsh3Tr6Aaik3oUk8UVSkOuxzaHkks/iVmk2 Ewo8ifcgeY+MAV5o41b2GAGPxTXo7S8qvJnu6kb8Yl+7QJ4XFFm71IKLyiY4WXpFuiNU rqX0X8ONceu3pGN9ZZVY0vOVaKZ5BErt2X1Az3DfLDLPqN0bkBceuCumBWe3545GA96r j/ydlIRtD0AMd7PQlFhV69vOOZLYq4bmlrWnNQF8QhazcrDzxvuOG426U01GEF1jGdid 41LA== X-Gm-Message-State: AD7BkJK8JiVH9XtZ/1KJXp7hkBwY9+8AtMzlfCmYHg3rul8e3g2JvsIiwYWFxMhqvZrQqSOkwlfZDuUNEr32wg== MIME-Version: 1.0 X-Received: by 10.107.37.12 with SMTP id l12mr278371iol.138.1459363035610; Wed, 30 Mar 2016 11:37:15 -0700 (PDT) Received: by 10.79.67.2 with HTTP; Wed, 30 Mar 2016 11:37:15 -0700 (PDT) In-Reply-To: <56FB46EA.7050401@uclinux.org> References: <56FB46EA.7050401@uclinux.org> Date: Wed, 30 Mar 2016 15:37:15 -0300 Message-ID: Subject: Re: [PATCH] net: fec: stop the "rcv is not +last, " error messages From: Fabio Estevam To: Greg Ungerer Cc: Troy Kisky , "netdev@vger.kernel.org" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Greg, On Wed, Mar 30, 2016 at 12:24 AM, Greg Ungerer wrote: > Hi Troy, > > Commit 55cd48c8 ('net: fec: stop the "rcv is not +last, " error > messages') adds a write to a register that is not present in all > implementations of the FEC hardware module. None of the ColdFire > SoC parts with the FEC module have the FTRL (0x1b0) register. > > Does this need a quirk flag to key access to this register of? > Or can you piggyback on the FEC_QUIRK_HAS_RACC flag? Would the change below work on Coldfire? --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -943,8 +943,8 @@ fec_restart(struct net_device *ndev) else val &= ~FEC_RACC_OPTIONS; writel(val, fep->hwp + FEC_RACC); - } writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL); + } #endif /*