From patchwork Tue May 14 19:27:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 243811 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BF2D42C009C for ; Wed, 15 May 2013 05:27:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757716Ab3ENT1H (ORCPT ); Tue, 14 May 2013 15:27:07 -0400 Received: from mail-ve0-f178.google.com ([209.85.128.178]:33095 "EHLO mail-ve0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755376Ab3ENT1G (ORCPT ); Tue, 14 May 2013 15:27:06 -0400 Received: by mail-ve0-f178.google.com with SMTP id jy13so1111145veb.23 for ; Tue, 14 May 2013 12:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=kDOLy1FECCLtAvOk+d2fO/BaqQe3NIfhqWXtby38jNo=; b=K2qY0zwPrfSU75LuMch+/QKRPQKD21vO9KKx/IkPxl+6XBwJS6KCzq6uw6Cy52swGQ 9uVgetWXGPNumtzxut3ZqCQH7u8hfz0CU9+QDCaVBBTOTCHzbLJBPkWGfBTNotGwPSg5 l/ZAtUWR/QD29aetLTgo6mGLmMgp8hg1eXFQL9yK274y/wte78fLvsFr/LhWyxwiJxQg sww3mqNd3stX2dMGZ/TFQlxPJb7wnfi/l4mNtnmBw+isLINoLSL+8oTgusPD3q0lzwyQ gjgXl7u+8GxXSUE9ixAKtIpt1OEXG8xJFd2e+78sDkudvcrZEN/+EjjaxemEWDZVrQY3 v+HQ== MIME-Version: 1.0 X-Received: by 10.58.106.77 with SMTP id gs13mr2207995veb.22.1368559624720; Tue, 14 May 2013 12:27:04 -0700 (PDT) Received: by 10.58.200.97 with HTTP; Tue, 14 May 2013 12:27:04 -0700 (PDT) In-Reply-To: <20130513045710.GA4440@S2101-09.ap.freescale.net> References: <1367971724-1974-1-git-send-email-Frank.Li@freescale.com> <20130513045710.GA4440@S2101-09.ap.freescale.net> Date: Tue, 14 May 2013 16:27:04 -0300 Message-ID: Subject: Re: [PATCH v5 1/1 net] net: fec: fix kernel oops when plug/unplug cable many times From: Fabio Estevam To: Shawn Guo Cc: Frank Li , romieu@fr.zoreil.com, r.schwebel@pengutronix.de, davem@davemloft.net, l.stach@pengutronix.de, netdev@vger.kernel.org, lznuaa@gmail.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, May 13, 2013 at 1:57 AM, Shawn Guo wrote: > The patch has landed on 3.10-rc1. Seems that it introduces a lock > warning as below. Turn on CONFIG_PROVE_LOCKING and you will be able > to see it. This makes the warning goes away on mx28: ,but not sure if it looks OK. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -451,7 +451,6 @@ fec_restart(struct net_device *ndev, int duplex) netif_device_detach(ndev); napi_disable(&fep->napi); netif_stop_queue(ndev); - netif_tx_lock(ndev); } /* Whack a reset. We should wait for this. */ @@ -619,7 +618,6 @@ fec_restart(struct net_device *ndev, int duplex) netif_device_attach(ndev); napi_enable(&fep->napi); netif_wake_queue(ndev); - netif_tx_unlock(ndev); } }