From patchwork Sat Jun 10 01:12:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 774177 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wl1PM1BCgz9s7v for ; Sat, 10 Jun 2017 11:13:11 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Qb52nB85"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751624AbdFJBNC (ORCPT ); Fri, 9 Jun 2017 21:13:02 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36034 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbdFJBNB (ORCPT ); Fri, 9 Jun 2017 21:13:01 -0400 Received: by mail-ot0-f196.google.com with SMTP id i31so7071920ota.3; Fri, 09 Jun 2017 18:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZSncm9zy0Dok8OrkBAB1UW6PITMfnyLKU7BgpMU8uHA=; b=Qb52nB85TW7yLjMYfyTAIQv1dj+OzsUwYQXYVvyCUULJ4W7+BbipQBlnYEq0rfEzcP 6bVnieYVT1JysWu3AdnhTXnUMv+lMvkwNmLgahFzFIaZTvqWP21ER4XqdLFLGIJZNIV1 ueYAByS1YOkNDSEEyLWbA/6ADRXkGLLOAASU5+igzfQcMNujnTDISVZTurNQDNnXPdsD 02qlaE8YWye3Hm9fd2I2VD2q2YIwXontWNOOYSVtMd+bG+oXopwl1Tu+v0zIghK482hL nqe31NKV2wqAhlG7H1j+hUJW9x0kHyjT9dmICyGiuNA9Thi4AXAeeAwyE9dn/X0hWO4i RKag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZSncm9zy0Dok8OrkBAB1UW6PITMfnyLKU7BgpMU8uHA=; b=fyeTVG3ZUenSYVDlsemoOZGKRBcrQ4qcDMnQE3BnuOZ/xwdtZ6sfaFc3ZUaSmGWM4J XnmUHvp1iSJWP3wcMjbjnlXVBkiM9CwbnEPid4IefsLYmi3COBeslK8uDf6/O8OyQ2pg Dbn66COS7IhrDH/nZGHnM+UmZMea7Sj+qd0WU7GxG9wCBpF8V8Eikjk+/IYbp9kuoTbF v3TU8pB0/LsvFS9/4hOWm7DeJul3Dp2zUFolM+bqluRJ/Oq521/B/PFrGQVZXq6p82Fi wr1aTVLsP6bMpNuwTh41ho046ITDn7roAujA/3s1QlRa7pBTARmBQT9/0Q7zXktLMfHn f77A== X-Gm-Message-State: AODbwcDIcckTmtp60c/1uuUpaIm1N2es/En7VJ2p0W0YtnKSjSuVJpUH w3J+9PK0sqOdqwObVz83j+39uEZIFw== X-Received: by 10.157.43.43 with SMTP id o40mr21550152otb.150.1497057180243; Fri, 09 Jun 2017 18:13:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.5 with HTTP; Fri, 9 Jun 2017 18:12:59 -0700 (PDT) In-Reply-To: References: <1496800629-24910-1-git-send-email-andrew@lunn.ch> <20170607.100742.9158707718791478.davem@davemloft.net> From: Fabio Estevam Date: Fri, 9 Jun 2017 22:12:59 -0300 Message-ID: Subject: Re: [PATCH net-next] net: fec: Clear and enable MIB counters on imx51 To: Paul Gortmaker Cc: David Miller , Andrew Lunn , netdev , Nikita Yushchenko , Fabio Estevam , Chris Healy , "linux-next@vger.kernel.org" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Paul, On Fri, Jun 9, 2017 at 10:01 PM, Paul Gortmaker wrote: > Seems to break one of the automated linux-next builds: > > http://kisskb.ellerman.id.au/kisskb/buildresult/13057702/ > > A mindless automated bisect reports: > > 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633 is the first bad commit > commit 2b30842b23b9e6796c7bd5f0916fd2ebf6b7d633 > Author: Andrew Lunn > Date: Wed Jun 7 03:57:09 2017 +0200 > > net: fec: Clear and enable MIB counters on imx51 This should fix it: /* ITR clock source is enet system clock (clk_ahb). Will test it and submit a formal patch in case it works. Thanks --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2379,6 +2379,10 @@ static void fec_enet_clear_ethtool_stats(struct net_device *dev) static inline void fec_enet_update_ethtool_stats(struct net_device *dev) { } + +static inline void fec_enet_clear_ethtool_stats(struct net_device *dev) +{ +} #endif /* !defined(CONFIG_M5272) */