From patchwork Mon Sep 18 06:00:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: duanjiong X-Patchwork-Id: 814784 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uKUbyb6V"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xwb2j4s6jz9s7c for ; Mon, 18 Sep 2017 16:00:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbdIRGA0 (ORCPT ); Mon, 18 Sep 2017 02:00:26 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:32978 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbdIRGAZ (ORCPT ); Mon, 18 Sep 2017 02:00:25 -0400 Received: by mail-lf0-f66.google.com with SMTP id y15so3948730lfd.0 for ; Sun, 17 Sep 2017 23:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=gdZiT9IfOT9U4letnHAtj/94snuFo2CD7Xyrky4rOAc=; b=uKUbyb6VowkJMefSE1n8R3lKQCasKDSMvqy6aOyZeZlO+D7MuL75xVcRuYLnviW+RU uXp5KI8d7sC5ah/guLPGbrZLweU4oyWYLXC1nDyqDbYkqilT24Eguai/G7FTpJSnxbOG vvcHd0kxLoKoPdAA2R4TFc6ho+wrTRoX4zKffhJnbZic26864WsKg/+BTlMm1vvy6LKy JpPiKBXqWDniXCixI19PePhTJCBIp6KHmvQgrhHYsIFf0Rm8Z/1aidS2pGpzWy8C77g6 DQpezRAJDwTMq23RRd2PLolk1H/iw7qsCipXA7zVeIaol31RvIyCOneqnNrQc6Yk89gK cROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=gdZiT9IfOT9U4letnHAtj/94snuFo2CD7Xyrky4rOAc=; b=AAj9+0mDoABYZm9dU+9cqpp5qa2CXrgFd1RNQUD9C9lyuGIn63l8PFjKbuXhHz0fDf kyxVELeQUvObAUtzUQAT+URt1CxwQ6wOn0OH/5O+ar9HrmL+3Yzv2DUIgXhxdL9B7RXp MHac2Iqihkqz+2hnE9/smX1dG9BBUoIKEQIcX0TKgMyjAnD7PPWaPhubIfFpoJntdDze MhBL1pJcctiO6fNRThKsDyJoCi05XbKDnFJHQ9BQGgTrlwMoW3FyfFMqsyd6HcN4NJ5/ ksVPVXtp0GqPcojLQ79FOyGWQfX5JMtiV+DEveSzK6/wdW4nMiT++bhpaCzqRC0DUDL4 gG9w== X-Gm-Message-State: AHPjjUgyvSxkBDswDdEgwu9fURj7aLw4n6rZ68Luy9fxV/rHioeCKIg8 FCz7e11j3m6cv7I0IwIYytzoWrRvMOnjEtkgkzoNXA== X-Google-Smtp-Source: AOwi7QBqQI47RGcJXqLX+Rqo3jLZjizX5VNQZf1me7oRDi2XahqP2jXVH7cCJG3ZadjtOA5nx1Gn5fhMGWID6aFjrIA= X-Received: by 10.25.79.8 with SMTP id d8mr2831260lfb.118.1505714424147; Sun, 17 Sep 2017 23:00:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.82.14 with HTTP; Sun, 17 Sep 2017 23:00:23 -0700 (PDT) From: Duan Jiong Date: Mon, 18 Sep 2017 14:00:23 +0800 Message-ID: Subject: [PATCH net-next] net: remove useless comments in dst.c To: netdev Cc: weiwan@google.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org dst gc related code has been removed in commit 5b7c9a8ff828, so those comments are no longer useful. Signed-off-by: Duan Jiong --- net/core/dst.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/net/core/dst.c b/net/core/dst.c index a6c47da..a710d39 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -25,23 +25,6 @@ #include #include -/* - * Theory of operations: - * 1) We use a list, protected by a spinlock, to add - * new entries from both BH and non-BH context. - * 2) In order to keep spinlock held for a small delay, - * we use a second list where are stored long lived - * entries, that are handled by the garbage collect thread - * fired by a workqueue. - * 3) This list is guarded by a mutex, - * so that the gc_task and dst_dev_event() can be synchronized. - */ - -/* - * We want to keep lock & list close together - * to dirty as few cache lines as possible in __dst_free(). - * As this is not a very strong hint, we dont force an alignment on SMP. - */ int dst_discard_out(struct net *net, struct sock *sk, struct sk_buff *skb) { kfree_skb(skb);