diff mbox series

[net-next] net: remove useless comments in dst.c

Message ID CALttK1QuA3tSdfSUPoYtoQV5reJdsVOicLX_9iN1TkwY6De6HQ@mail.gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show
Series [net-next] net: remove useless comments in dst.c | expand

Commit Message

duanjiong Sept. 18, 2017, 6 a.m. UTC 
dst gc related code has been removed in commit
5b7c9a8ff828, so those comments are no longer
useful.

Signed-off-by: Duan Jiong <jduan@fiberhome.com>
---
 net/core/dst.c | 17 -----------------
 1 file changed, 17 deletions(-)

Comments

Sergei Shtylyov Sept. 18, 2017, 10:24 a.m. UTC | #1 
Hello!

On 9/18/2017 9:00 AM, Duan Jiong wrote:

> dst gc related code has been removed in commit
> 5b7c9a8ff828, so those comments are no longer

    Please also specify the commit's summary line enclosed in ("").

> useful.
> 
> Signed-off-by: Duan Jiong <jduan@fiberhome.com>
[...]

MBR, Sergei
diff mbox series

Patch

diff --git a/net/core/dst.c b/net/core/dst.c
index a6c47da..a710d39 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -25,23 +25,6 @@ 
 #include <net/dst.h>
 #include <net/dst_metadata.h>

-/*
- * Theory of operations:
- * 1) We use a list, protected by a spinlock, to add
- *    new entries from both BH and non-BH context.
- * 2) In order to keep spinlock held for a small delay,
- *    we use a second list where are stored long lived
- *    entries, that are handled by the garbage collect thread
- *    fired by a workqueue.
- * 3) This list is guarded by a mutex,
- *    so that the gc_task and dst_dev_event() can be synchronized.
- */
-
-/*
- * We want to keep lock & list close together
- * to dirty as few cache lines as possible in __dst_free().
- * As this is not a very strong hint, we dont force an alignment on SMP.
- */
 int dst_discard_out(struct net *net, struct sock *sk, struct sk_buff *skb)
 {
  kfree_skb(skb);