From patchwork Thu Mar 21 10:02:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zhi Li X-Patchwork-Id: 229617 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E8EE22C00F1 for ; Thu, 21 Mar 2013 21:02:11 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932356Ab3CUKCG (ORCPT ); Thu, 21 Mar 2013 06:02:06 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:48881 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757594Ab3CUKCF convert rfc822-to-8bit (ORCPT ); Thu, 21 Mar 2013 06:02:05 -0400 Received: by mail-wg0-f44.google.com with SMTP id dr12so2036978wgb.11 for ; Thu, 21 Mar 2013 03:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:content-transfer-encoding; bh=uCIlZvRmF4ohxKdGksYJy5QURu7DVlu+NMgo9Fkjaoo=; b=as0Zmkh1XrI+tIGgpYo/uw+BONmya/dNHtzxbsbnn53JUkHRN0eoPhh+B0nesVDYkV QBTgaZuS+ID2H41QOuFDmj1WcUePmBXk8ECApbuzH8lAy598IgZFgKDQjiTMRdKJl0bo 5YSV17dLBeQ2m9U5ypjWZWPaOMuCT1Kq/pyVizr/cDvlClVdRnWULywsSUZZkt+xECbR rORin8xY4s5kqdgN412zMnytC0D4yPgoY0UGcX1e3Fp+DH5nT06JKJkIGWzk+fkvGNnx KarLZJKgcQsLC/XYvpp6igmdacdVW1WZWrAZPn7gRrELnNBgofUWKw7edXEUv4G/O2/9 e+4Q== MIME-Version: 1.0 X-Received: by 10.194.110.69 with SMTP id hy5mr16011527wjb.1.1363860122736; Thu, 21 Mar 2013 03:02:02 -0700 (PDT) Received: by 10.227.55.19 with HTTP; Thu, 21 Mar 2013 03:02:02 -0700 (PDT) In-Reply-To: <20130321062146.GL20530@pengutronix.de> References: <1363810268-24398-1-git-send-email-festevam@gmail.com> <20130321062146.GL20530@pengutronix.de> Date: Thu, 21 Mar 2013 18:02:02 +0800 Message-ID: Subject: Re: [PATCH] fec: Unify fec_ptp.c and fec.c From: Frank Li To: =?ISO-8859-1?Q?Uwe_Kleine=2DK=F6nig?= Cc: Fabio Estevam , davem@davemloft.net, Frank.Li@freescale.com, netdev@vger.kernel.org, Fabio Estevam Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I suggest use below patch to fix this problem 2013/3/21 Uwe Kleine-König : > Hello Fabio, > > On Wed, Mar 20, 2013 at 05:11:07PM -0300, Fabio Estevam wrote: >> Currently CONFIG_FEC=y generates two separate modules: fec_ptp.ko and fec.ko. > CONFIG_FEC=m > >> These modules cannot be used independently, so it is better to unify them. >> >> Move fec_ptp.c code into fec.c and its definitions into fec.h. >> >> Suggested-by: Uwe Kleine-Koenig > s/Koe/Kö/ > >> Signed-off-by: Fabio Estevam > > You could note that you dropped the EXPORT_SYMBOLs. Other than that I > assume it's a 1:1 change? > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ | > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/ethernet/freescale/Makefile +++ b/drivers/net/ethernet/freescale/Makefile @@ -2,7 +2,8 @@ # Makefile for the Freescale network device drivers. # -obj-$(CONFIG_FEC) += fec.o fec_ptp.o +obj-$(CONFIG_FEC) += fec_driver.o +fec_driver-objs := fec.o fec_ptp.o obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y) obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o