From patchwork Thu Jun 1 15:15:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soheil Hassas Yeganeh X-Patchwork-Id: 769786 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wdrX50HyBz9sDG for ; Fri, 2 Jun 2017 01:16:05 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="pbXwu7pU"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751168AbdFAPP4 (ORCPT ); Thu, 1 Jun 2017 11:15:56 -0400 Received: from mail-it0-f49.google.com ([209.85.214.49]:38874 "EHLO mail-it0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdFAPPy (ORCPT ); Thu, 1 Jun 2017 11:15:54 -0400 Received: by mail-it0-f49.google.com with SMTP id r63so38124113itc.1 for ; Thu, 01 Jun 2017 08:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1bcMm9sixpFPGQMXNNV0s2KH02iCpzxrAU737oPgV5E=; b=pbXwu7pU/hbszZBsANfrWanbvQaJhVGrg6Uxl50FX4Z8rgsUf6rDWl2LyblrWlLP4d 9DK91z+cUY/Am6tPWCJ1WSPQLJ66YiLbsHTcY+RKWlD6OR5RJsBNPJ2/82hDBCR4G38E EdPzZlv75+12QfHLbWQ7gI0z6U2a9qmuKe47Vcg84U8Z3nMLGxv5PYqbGSPqxnzQyIXX HIGcezaiUA8Qsjr4B7cPMZeQDZljOcxvvcFb1N0/LsnQvwafzCD2V3RksVq3mp7VbGGs Zl50Kp0zHjUriVbQhgdEShgAp+iGe3UKEDhjBvlJLsNYCMmRbXKMp2DVfZg/Tg/UcAYb To9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1bcMm9sixpFPGQMXNNV0s2KH02iCpzxrAU737oPgV5E=; b=Cy8+1efSXegxlejj0mPOMV+NsShbXjiaO8okXOVw76ukPuZ4kzSSFxD3R6TU7ee9xZ kzxUP0o6aNqGBs5+u1/rBhYgD2I2X3IuRNAxK6C8eas/UYyP1xFPOGXWQtkzkmmDA9zd 74uPNhGmnVYwQwVuMljjEqElu9zQPh2296Z5ogFLtC9Z5s0BVyeaFzYuqXlolk3qrHoB aR/aA519l7TRJ2k2z4JylD4BBdOkVt7o3AqvPd1CR5A4RUZ6JMvxYkW2ydJASLoYKiwX Q//WjP0pcU1bYiiym2Sl1V1pDSzwWaYpb0ILB9AyZIzdnO1sNKVI9dU3vhJyYULp4Epp rHFg== X-Gm-Message-State: AODbwcCxrYFb4jSFRkEhI223IIq1jzVtYaOIjuxsMB1mjv+jwlxiYWRc tQTDhR+PWg26XWvf6bkpocOH33fRKNKp X-Received: by 10.36.89.193 with SMTP id p184mr10248888itb.107.1496330153080; Thu, 01 Jun 2017 08:15:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.3.194 with HTTP; Thu, 1 Jun 2017 08:15:12 -0700 (PDT) In-Reply-To: <20170601151003.GB10526@rei.suse.de> References: <20170601140048.GA24401@rei.lan> <20170601143141.GB24401@rei.lan> <20170601151003.GB10526@rei.suse.de> From: Soheil Hassas Yeganeh Date: Thu, 1 Jun 2017 11:15:12 -0400 Message-ID: Subject: Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping To: Cyril Hrubis Cc: "David S. Miller" , Shmulik Ladkani , Marcelo Ricardo Leitner , Pravin B Shelar , Eric Dumazet , WANG Cong , Yaogong Wang , Steffen Klassert , Al Viro , netdev , linux-kernel@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis wrote: >> Thank you for the confirmation. Could you please try the following >> patch to see if it fixes your issue? > > Does not seem to help, I still got the same bussy loop. Thank you for trying the patch. Unfortunately, I can't reproduce on my machines here.Would you humor me with another one? Thank you! diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 5a726161f4e4..49207298fcea 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3742,7 +3742,8 @@ EXPORT_SYMBOL(sock_queue_err_skb); static bool is_icmp_err_skb(const struct sk_buff *skb) { return skb && (SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP || - SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6); + SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6 || + SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_LOCAL); } struct sk_buff *sock_dequeue_err_skb(struct sock *sk)