From patchwork Sun Aug 7 13:03:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: huajun li X-Patchwork-Id: 108818 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8C6C2B6F75 for ; Sun, 7 Aug 2011 23:03:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790Ab1HGNDe (ORCPT ); Sun, 7 Aug 2011 09:03:34 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:46222 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735Ab1HGNDc (ORCPT ); Sun, 7 Aug 2011 09:03:32 -0400 Received: by fxh19 with SMTP id 19so4406381fxh.19 for ; Sun, 07 Aug 2011 06:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=MAjludJPEURL3rQ8FQvftNaN0Q7wNkiGxeYtR/kOi7Y=; b=WZb3GBcjtsCG7KtPP4Zj3iL1/MojuIEGQvfGRDvsjAeUojL63BpoeNdIiIBEUFlAgd y+O4bWUFbdxaNhl8mFKs+RyculIp3zDaSsoAWzuR2O+NzN2RWfD8Nid2PHaqzItY5jYn DA2uh9Bqztg04e2Sifil/rQ8DunKz02Y5gowM= MIME-Version: 1.0 Received: by 10.223.26.131 with SMTP id e3mr1367119fac.60.1312722211186; Sun, 07 Aug 2011 06:03:31 -0700 (PDT) Received: by 10.223.90.201 with HTTP; Sun, 7 Aug 2011 06:03:31 -0700 (PDT) Date: Sun, 7 Aug 2011 21:03:31 +0800 Message-ID: Subject: rtl8150: rtl8150_disconnect(...) does not need tasklet_disable(...) From: Huajun Li To: David Miller , petkan@users.sourceforge.net Cc: netdev , lud , Huajun Li Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Executing cmd 'rmmod rtl8150' does not return(if your device connects to host), the root cause is tasklet_disable() causes tasklet_kill() block, remove it from rtl8150_disconnect(). Signed-off-by: Huajun Li --- drivers/net/usb/rtl8150.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c index 041fb7d..ef3b236 100644 --- a/drivers/net/usb/rtl8150.c +++ b/drivers/net/usb/rtl8150.c @@ -977,7 +977,6 @@ static void rtl8150_disconnect(struct usb_interface *intf) usb_set_intfdata(intf, NULL); if (dev) { set_bit(RTL8150_UNPLUG, &dev->flags); - tasklet_disable(&dev->tl); tasklet_kill(&dev->tl); unregister_netdev(dev->netdev); unlink_all_urbs(dev);