From patchwork Thu Jul 21 08:42:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: huajun li X-Patchwork-Id: 106016 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F1DE1B6F77 for ; Thu, 21 Jul 2011 18:42:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752603Ab1GUImU (ORCPT ); Thu, 21 Jul 2011 04:42:20 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:39843 "EHLO mail-fx0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905Ab1GUImT convert rfc822-to-8bit (ORCPT ); Thu, 21 Jul 2011 04:42:19 -0400 Received: by fxd18 with SMTP id 18so3209610fxd.11 for ; Thu, 21 Jul 2011 01:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=/l/Jmlrx817FpxFtlRFDj163rwMgLKLR5Z70PZ4Hx3k=; b=gKVuxVwgsClRVaRAVKBEwIDlF3RNNKq4hB0NimgEUXhLgkcPnTtdOzOAqP9zbaAgaJ fmxdIHxXzIHeBzw3BWTynVbo02BxndVgKzsyOp7/BwdhKT9ZzK13NahwaYLPkwbWV18k pSLj/6gMUkvoouqBDcSiq8XUEmJOizFCcmzUU= MIME-Version: 1.0 Received: by 10.223.6.77 with SMTP id 13mr1769905fay.41.1311237737946; Thu, 21 Jul 2011 01:42:17 -0700 (PDT) Received: by 10.223.124.202 with HTTP; Thu, 21 Jul 2011 01:42:17 -0700 (PDT) In-Reply-To: <20110721054033.GA8299@verge.net.au> References: <20110720205019.9dfa30c3.rdunlap@xenotime.net> <20110721054033.GA8299@verge.net.au> Date: Thu, 21 Jul 2011 16:42:17 +0800 Message-ID: Subject: Re: ipvs oops in 3.0-rc7 From: Huajun Li To: Simon Horman Cc: Randy Dunlap , netdev , lvs-devel@vger.kernel.org, Wensong Zhang , Julian Anastasov , huajun li Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Randy and Simon, I happened to meet the issue too, loading and unloading module of ip_vs, then loading it again will cause Oops, the root cause may be ip_vs_dst_notifier is not unregistered. Please try following patch, it works for me. Signed-off-by: Huajun Li Reported-by: Randy Dunlap Acked-by: Randy Dunlap --- net/netfilter/ipvs/ip_vs_ctl.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c index 699c79a..a178cb3 100644 --- a/net/netfilter/ipvs/ip_vs_ctl.c +++ b/net/netfilter/ipvs/ip_vs_ctl.c @@ -3771,6 +3771,7 @@ err_sock: void ip_vs_control_cleanup(void) { EnterFunction(2); + unregister_netdevice_notifier(&ip_vs_dst_notifier); ip_vs_genl_unregister(); nf_unregister_sockopt(&ip_vs_sockopts); LeaveFunction(2);