From patchwork Thu Apr 22 21:23:30 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Scott Feldman X-Patchwork-Id: 50759 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4A15EB7BEE for ; Fri, 23 Apr 2010 07:24:12 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758875Ab0DVVXj (ORCPT ); Thu, 22 Apr 2010 17:23:39 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:45574 "EHLO sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758302Ab0DVVXe (ORCPT ); Thu, 22 Apr 2010 17:23:34 -0400 Authentication-Results: sj-iport-6.cisco.com; dkim=neutral (message not signed) header.i=none X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEANda0EurRN+K/2dsb2JhbACcKnGnIpo2hQ8EgzQ X-IronPort-AV: E=Sophos;i="4.52,258,1270425600"; d="scan'208";a="519184902" Received: from sj-core-4.cisco.com ([171.68.223.138]) by sj-iport-6.cisco.com with ESMTP; 22 Apr 2010 21:23:33 +0000 Received: from xbh-sjc-211.amer.cisco.com (xbh-sjc-211.cisco.com [171.70.151.144]) by sj-core-4.cisco.com (8.13.8/8.14.3) with ESMTP id o3MLNX6X013523; Thu, 22 Apr 2010 21:23:33 GMT Received: from xmb-sjc-23d.amer.cisco.com ([128.107.191.14]) by xbh-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 22 Apr 2010 14:23:33 -0700 Received: from 10.21.148.143 ([10.21.148.143]) by xmb-sjc-23d.amer.cisco.com ([128.107.191.14]) via Exchange Front-End Server email.cisco.com ([171.70.151.174]) with Microsoft Exchange Server HTTP-DAV ; Thu, 22 Apr 2010 21:23:32 +0000 User-Agent: Microsoft-Entourage/12.24.0.100205 Date: Thu, 22 Apr 2010 14:23:30 -0700 Subject: Re: [net-next PATCH 1/2] add iovnl netlink support From: Scott Feldman To: David Miller CC: , Message-ID: Thread-Topic: [net-next PATCH 1/2] add iovnl netlink support Thread-Index: AcriYg3Rt8vn4ct+oEikTJgaroim8A== In-Reply-To: <20100421.234849.51685723.davem@davemloft.net> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit X-OriginalArrivalTime: 22 Apr 2010 21:23:33.0344 (UTC) FILETIME=[0FCFF600:01CAE262] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/21/10 11:48 PM, "David Miller" wrote: > From: Scott Feldman > Date: Mon, 19 Apr 2010 12:18:07 -0700 > >> +#define IOVNL_PROTO_VERSION 1 >> + > > Please delete this in the final version, the macro isn't even used by > the code. > > We don't do protocol versioning in netlink. Instead we get the base > stuff solid from the beginning, and then if something needs fixing up > we handle this using new attributes in a way which is both backward > and forward compatible. Sounds good to me, was a cut-and-paste from dcbnl.h. How about: -scott --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/dcbnl.h b/include/linux/dcbnl.h index b7cdbb4..8723491 100644 --- a/include/linux/dcbnl.h +++ b/include/linux/dcbnl.h @@ -22,8 +22,6 @@ #include -#define DCB_PROTO_VERSION 1 - struct dcbmsg { __u8 dcb_family; __u8 cmd;