From patchwork Thu Mar 17 11:41:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vineet Gupta X-Patchwork-Id: 599003 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qQmfQ0Q4yz9sD5 for ; Thu, 17 Mar 2016 22:41:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935789AbcCQLlf (ORCPT ); Thu, 17 Mar 2016 07:41:35 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:35182 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933349AbcCQLle convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 07:41:34 -0400 Received: from us02secmta1.synopsys.com (us02secmta1.synopsys.com [10.12.235.96]) by smtprelay.synopsys.com (Postfix) with ESMTP id 208CB24E112F; Thu, 17 Mar 2016 04:41:33 -0700 (PDT) Received: from us02secmta1.internal.synopsys.com (us02secmta1.internal.synopsys.com [127.0.0.1]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id 142A64E213; Thu, 17 Mar 2016 04:41:33 -0700 (PDT) Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by us02secmta1.internal.synopsys.com (Service) with ESMTP id BB1854E202; Thu, 17 Mar 2016 04:41:32 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id A4186AE1; Thu, 17 Mar 2016 04:41:32 -0700 (PDT) Received: from US01WEHTC2.internal.synopsys.com (us01wehtc2.internal.synopsys.com [10.12.239.237]) by mailhost.synopsys.com (Postfix) with ESMTP id 90CF2ADF; Thu, 17 Mar 2016 04:41:32 -0700 (PDT) Received: from us01wembx1.internal.synopsys.com ([169.254.1.89]) by US01WEHTC2.internal.synopsys.com ([10.12.239.237]) with mapi id 14.03.0195.001; Thu, 17 Mar 2016 04:41:32 -0700 From: Vineet Gupta To: Alexey Brodkin , "sergei.shtylyov@cogentembedded.com" CC: "robh@kernel.org" , "preid@electromag.com.au" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "davem@davemloft.net" Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Thread-Topic: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Thread-Index: AQHRgDFXNOSRRka9PESGJ+Dm4Wx28Q== Date: Thu, 17 Mar 2016 11:41:30 +0000 Message-ID: References: <1458207712-29435-1-git-send-email-abrodkin@synopsys.com> <56EA8DCC.8070308@cogentembedded.com> <1458214678.14496.15.camel@synopsys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thursday 17 March 2016 05:08 PM, Alexey Brodkin wrote: > Hi Sergei, > > On Thu, 2016-03-17 at 13:58 +0300, Sergei Shtylyov wrote: >> On 3/17/2016 12:41 PM, Alexey Brodkin wrote: >> >>> Following commit broke DW GMAC functionality on AXS10x boards: >>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 >> Note that scripts/checkpatch.pl now enforces certain format for citing >> commits: commit <12-digit SHA1> (""). > Frankly I haven't run that patch through checkpatch due to patch > simplicity. > > But I'll try to not do any assumptions from now on and will try to > use checkpatch for each and every thing I send :) > > Thanks for spotting all his! > > -Alexey Sergei, do you mind providing a Ack/Reviewed-by on the patch below --------> From 67216d835d8c2a5748ba1631c8bfc19da4fb87fa Mon Sep 17 00:00:00 2001 From: Alexey Brodkin Date: Thu, 17 Mar 2016 12:41:52 +0300 Subject: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Commit e34d65696d2e ("stmmac: create of compatible mdio bus for stmmac driver") broke DW GMAC functionality on ARC AXS10x boards: That's what happens on eth0 up: --------------------------->8------------------------ | libphy: PHY stmmac-0:ffffffff not found | eth0: Could not attach to PHY | stmmac_open: Cannot attach to PHY (error: -19) --------------------------->8------------------------ Simplest solution is to add PHY description in board's .dts. And so we do here. Signed-off-by: Alexey Brodkin Cc: Rob Herring Cc: Phil Reid Cc: David S. Miller Cc: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org Cc: stable@vger.kernel.org # 4.5 Cc: Sergei Shtylyov Signed-off-by: Vineet Gupta Reviewed-by: Sergei Shtylyov --- arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi index 44a578c10732..ab5d5701e11d 100644 --- a/arch/arc/boot/dts/axs10x_mb.dtsi +++ b/arch/arc/boot/dts/axs10x_mb.dtsi @@ -47,6 +47,14 @@ clocks = <&apbclk>; clock-names = "stmmaceth"; max-speed = <100>; + mdio0 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + phy1: ethernet-phy@1 { + reg = <1>; + }; + }; }; ehci@0x40000 {