From patchwork Fri Jun 3 20:07:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Casey Leedom X-Patchwork-Id: 629997 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rLwXX5q29z9t89 for ; Sat, 4 Jun 2016 06:23:40 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chelsious.onmicrosoft.com header.i=@chelsious.onmicrosoft.com header.b=knngtHFP; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932600AbcFCUXj (ORCPT ); Fri, 3 Jun 2016 16:23:39 -0400 Received: from mail-bn1bon0119.outbound.protection.outlook.com ([157.56.111.119]:39842 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752441AbcFCUXh convert rfc822-to-8bit (ORCPT ); Fri, 3 Jun 2016 16:23:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chelsious.onmicrosoft.com; s=selector1-chelsio-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dVdMj2IAsxd7Q5ZZXIOwKjAcgRf4Q85TD+9pbSgv1lQ=; b=knngtHFP5pOUgPoIpUl0iicobg73ZQ+0BXE1CESH+UGJa06WXwW8OmDSN5AmDg9xQI/D52JShSTxYzyLUg69g0XLBankkTfZLI2/F9Xifm6Gw1pFmnKq85MEY1qj6iorxxMpBOdIL7osykfgrbwhSe3BgmLmCWVi97rVDNoTRE4= Received: from BY2PR12MB0648.namprd12.prod.outlook.com (10.163.113.15) by BY2PR12MB0648.namprd12.prod.outlook.com (10.163.113.15) with Microsoft SMTP Server (TLS) id 15.1.506.9; Fri, 3 Jun 2016 20:07:58 +0000 Received: from BY2PR12MB0648.namprd12.prod.outlook.com ([10.163.113.15]) by BY2PR12MB0648.namprd12.prod.outlook.com ([10.163.113.15]) with mapi id 15.01.0506.013; Fri, 3 Jun 2016 20:07:58 +0000 From: Casey Leedom To: Hariprasad S , "davem@davemloft.net" CC: "netdev@vger.kernel.org" , Nirranjan Kirubaharan Subject: Re: [PATCH net-next] cxgb4: Reduce resource allocation in kdump kernel Thread-Topic: [PATCH net-next] cxgb4: Reduce resource allocation in kdump kernel Thread-Index: AQHRvb2jXgfajGoiXkiqZ4OaXUEvgJ/YK1w+ Date: Fri, 3 Jun 2016 20:07:57 +0000 Message-ID: References: <1464975345-12484-1-git-send-email-hariprasad@chelsio.com> In-Reply-To: <1464975345-12484-1-git-send-email-hariprasad@chelsio.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: chelsio.com; dkim=none (message not signed) header.d=none; chelsio.com; dmarc=none action=none header.from=chelsio.com; x-originating-ip: [132.245.81.133] x-ld-processed: 065db76d-a7ae-4c60-b78a-501e8fc17095,ExtAddr,ExtAddr x-ms-office365-filtering-correlation-id: 706b6a57-fe3b-47e4-3914-08d38beac201 x-microsoft-exchange-diagnostics: 1; BY2PR12MB0648; 5:IYCcmKFHAilpRL3GPpnU7FKKnU5vCekhIXesOr2ghhe1VfPLIMuWQ4AhGtgFyZf2nQvy1XKXu7LLRMIEbwIRCuoZRLR8k/uUhTxSyQggedhY2lqrU5NtBtSgKVEAXJT/EH56H75Wg4iLc0dexu4AgQ==; 24:T9apO44SjxykJ3TkCMGIVA8SoyIRym5wdzKH8kYin3WXqw0lEBOW7qdVTVE8L/jkHAt90d9a98JxRKHO48w6ZQnmigpzqrc7f+qz1qMHvWA=; 7:+mL5f12ZLHJTgZXPWkebOjgEc6F3Y7L5C8+FOZDjbxmZ9DnPx9HrYejhBVk/S7zWB4wrU3n3iQHUpATjirpaKZ+wrViUvgkZxYtlUD2Hgxg1lLA/6nc0PehhACcDdn5ZfHKSQJ0R8/m+1PaO/pfLZ4ksZxnOZGjUldFyS4VQ0uQTECHjnfavrFLKQU0e3lWnoGjBZJ2tLc6gInwDiklq963/J6GiJq6llQn5uXboUSQ= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0648; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041072)(6043046); SRVR:BY2PR12MB0648; BCL:0; PCL:0; RULEID:; SRVR:BY2PR12MB0648; x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(377454003)(99286002)(5002640100001)(5004730100002)(11100500001)(106116001)(122556002)(33656002)(586003)(3280700002)(92566002)(107886002)(2501003)(76576001)(9686002)(189998001)(3660700001)(87936001)(5003600100002)(81166006)(2900100001)(50986999)(2950100001)(86362001)(19580405001)(10400500002)(6116002)(3846002)(102836003)(19580395003)(4001430100002)(5001770100001)(54356999)(76176999)(8936002)(4326007)(5008740100001)(66066001)(74316001)(2906002)(77096005)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR12MB0648; H:BY2PR12MB0648.namprd12.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: chelsio.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2016 20:07:57.7371 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 065db76d-a7ae-4c60-b78a-501e8fc17095 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0648 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Looks good to me. Of course I came up with those changes so maybe we should get another reviewer? :-) Also, don't forget to mention "Bug #29998" in the commit message ... Casey diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index 477db477b133..5317187d0073 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -64,6 +64,7 @@ #include #include #include +#include #include "cxgb4.h" #include "t4_regs.h" @@ -3735,7 +3736,8 @@ static int adap_init0(struct adapter *adap) return ret; /* Contact FW, advertising Master capability */ - ret = t4_fw_hello(adap, adap->mbox, adap->mbox, MASTER_MAY, &state); + ret = t4_fw_hello(adap, adap->mbox, adap->mbox, + is_kdump_kernel() ? MASTER_MUST : MASTER_MAY, &state); if (ret < 0) { dev_err(adap->pdev_dev, "could not connect to FW, error %d\n", ret); @@ -4366,6 +4368,14 @@ static void cfg_queues(struct adapter *adap) if (q10g > netif_get_num_default_rss_queues()) q10g = netif_get_num_default_rss_queues(); + /* Reduce memory usage in kdump environment by using only one queue + * and disable all offload. + */ + if (is_kdump_kernel()) { + q10g = 1; + adap->params.offload = 0; + } + for_each_port(adap, i) { struct port_info *pi = adap2pinfo(adap, i);