From patchwork Thu Jun 8 18:02:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joao Pinto X-Patchwork-Id: 773413 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wkCvW5bNTz9s74 for ; Fri, 9 Jun 2017 04:03:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbdFHSDB (ORCPT ); Thu, 8 Jun 2017 14:03:01 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:57939 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbdFHSC7 (ORCPT ); Thu, 8 Jun 2017 14:02:59 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 1F2A524E1EE7; Thu, 8 Jun 2017 11:02:59 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id E99DE11D; Thu, 8 Jun 2017 11:02:58 -0700 (PDT) Received: from jpinto-box.internal.synopsys.com (jpinto-box.internal.synopsys.com [10.107.19.150]) by mailhost.synopsys.com (Postfix) with ESMTP id 893DE110; Thu, 8 Jun 2017 11:02:57 -0700 (PDT) From: Joao Pinto To: davem@davemloft.net Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com, alexandre.torgue@st.com, Joao Pinto Subject: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters Date: Thu, 8 Jun 2017 19:02:52 +0100 Message-Id: <95bf7beef1abfb3c140ef56a8f59374bf6513496.1496944749.git.jpinto@synopsys.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <014297b3b5a1654eda19f099082d04b79a98b16a.1496944749.git.jpinto@synopsys.com> References: <014297b3b5a1654eda19f099082d04b79a98b16a.1496944749.git.jpinto@synopsys.com> In-Reply-To: <014297b3b5a1654eda19f099082d04b79a98b16a.1496944749.git.jpinto@synopsys.com> References: <014297b3b5a1654eda19f099082d04b79a98b16a.1496944749.git.jpinto@synopsys.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes the description of the DT AVB parameters and gives an accurate example. It was also included the base values that were used to get the example' CBS paremeter values. Signed-off-by: Joao Pinto --- Documentation/devicetree/bindings/net/stmmac.txt | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index c3a7be6..707426d 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/bindings/net/stmmac.txt @@ -109,10 +109,10 @@ Optional properties: [Attention] Queue 0 is reserved for legacy traffic and so no AVB is available in this queue. - Configure Credit Base Shaper (if AVB Mode selected): - - snps,send_slope: enable Low Power Interface - - snps,idle_slope: unlock on WoL - - snps,high_credit: max write outstanding req. limit - - snps,low_credit: max read outstanding req. limit + - snps,send_slope: Send Slope Credit value + - snps,idle_slope: Idle Slope Credit value + - snps,high_credit: High Credit value + - snps,low_credit: Low Credit value - snps,priority: TX queue priority (Range: 0x0 to 0xF) Examples: @@ -143,10 +143,18 @@ Examples: queue1 { snps,avb-algorithm; - snps,send_slope = <0x1000>; - snps,idle_slope = <0x1000>; - snps,high_credit = <0x3E800>; - snps,low_credit = <0xFFC18000>; + /* + * Example AVB parameters based on: + * Allocated Bandwidth: 40% + * Maximum Frame size: 1000 bytes + * Maximum Interference size: 1500 bytes + * Port Transmit Rate: 8 + * Scaling Factor: 1024 + */ + snps,idle_slope = <0xCCC>; + snps,send_slope = <0x1333>; + snps,high_credit = <0x4B0000>; + snps,low_credit = <0xFFB50000>; snps,priority = <0x1>; }; };