From patchwork Sat Dec 16 19:44:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 849548 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u+QpmNIS"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yzd6p0qT9z9s03 for ; Sun, 17 Dec 2017 06:44:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757026AbdLPToh (ORCPT ); Sat, 16 Dec 2017 14:44:37 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36596 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756815AbdLPToc (ORCPT ); Sat, 16 Dec 2017 14:44:32 -0500 Received: by mail-pg0-f65.google.com with SMTP id k134so7627325pga.3; Sat, 16 Dec 2017 11:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=EQxZYyGa85lRIuNlaFlTu3WSbnf1WtBCbhvM1M44aw8=; b=u+QpmNISjMeyR+yZJsUSBl9sPdBAqUxzh11/EqubGRFfTd9bu7hXSo6mw1hfUiZixb iPOiS8lG1OyqCYIq+/YM09bMkFZNjZq0ag/UTgcWB2pxfW5iff9FtcWQeuXtoHWLlwZ7 3va3AbOhQ2FpN7n8vFbhPCHwhEXE8qxjJvMYIFobrcCy0i4DhkgDxgsBJFxqjPIwqdJD vGa5FG4Yf12nUlic26GwbVvcI0TQaEjnrM1ZceJBeNmqyIhpTHwhRgE+zbwCacFrr+RT /eT3IOUGnUkS/FsR8CjKCEb1JVUVDy+eJYgcD/PwvxcCPFFq/Ghlu6xgPCPEBAKpl5Oy Zz6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EQxZYyGa85lRIuNlaFlTu3WSbnf1WtBCbhvM1M44aw8=; b=kdYw6/LNUepuCvzKE6zKJNzBHOeSHmkPls84LVfmgls04G6o6FvIwnsm63VxwjakSZ FQQ8LFlYCRC72rFztAaUvCR3ue9mX0Jro1SXGmxeumoPz6wSmwmQlRRzR0l/PNztJ0f2 apRkUEWUn4tHsCrH4Nid8AV2KqdqC7YAmnhQbVRHuA1i2O7t/h1Nny1Twqc8Fev8PmAb qMkp7X+Rb7hxtULew2Mem/a87w6HFXlIcR8MqdVyJP4QVlBnGtP2WJ+n0O8sJ8njf15E JxYFgjt5mD/1H2a3r0b3zGPqaldAbB64y1O5G0w4+CMMqA2FfEraMEVc9UG0vBVINuJT xtEQ== X-Gm-Message-State: AKGB3mLR8WSELcI0QA5DBPK/EAOylJjfgKV9HMrVDT7rvhRXjcp06xH2 N5Xm/vZCogJDkF8jg83SGmg= X-Google-Smtp-Source: ACJfBoujC34l/VKlOBUtAYwe35tCxVa7DY5dxiOSo9hOE0iAprNft4plSQdrgtPHZjL/74zrrx2LpQ== X-Received: by 10.98.158.89 with SMTP id s86mr13723096pfd.216.1513453471494; Sat, 16 Dec 2017 11:44:31 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id p13sm16589711pgn.32.2017.12.16.11.44.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 16 Dec 2017 11:44:30 -0800 (PST) From: Arvind Yadav To: sameo@linux.intel.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] NFC: Handle return value of skb_dequeue() Date: Sun, 17 Dec 2017 01:14:20 +0530 Message-Id: <8a2fd474b3c7a14e13852f0947544aad8f0ae169.1513453148.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb_dequeue() will return NULL for an empty list or a pointer to the head element. Signed-off-by: Arvind Yadav --- net/nfc/rawsock.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c index e2188de..c6de1ac 100644 --- a/net/nfc/rawsock.c +++ b/net/nfc/rawsock.c @@ -201,6 +201,10 @@ static void rawsock_tx_work(struct work_struct *work) } skb = skb_dequeue(&sk->sk_write_queue); + if (!skb) { + rawsock_write_queue_purge(sk); + return; + } sock_hold(sk); rc = nfc_data_exchange(dev, target_idx, skb,