From patchwork Thu Jan 31 22:35:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 1034503 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="dwO9sAJE"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43rFS42pZPz9sDX for ; Fri, 1 Feb 2019 09:35:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729693AbfAaWfa (ORCPT ); Thu, 31 Jan 2019 17:35:30 -0500 Received: from mail-eopbgr70075.outbound.protection.outlook.com ([40.107.7.75]:14830 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729402AbfAaWf3 (ORCPT ); Thu, 31 Jan 2019 17:35:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tgXeXX4jTJL2xcZnCGYD1KoeZqAUkLomVqiAZH3tT14=; b=dwO9sAJEryo+NI6qjI6BWmzsP+HlXCRe/yK/UU4tCscAOW3bNxM1hioktZpQF+pewhcnZvr65Nd3aQtHGPmrzGK8biTvfRkI6bcQm9z1Bn0lYQsrPGHvs5bYTtUVc/7TG3ppc603+dj11in1u0uKaaMlXVsmPwmCLB42F0d4mhY= Received: from AM6PR05MB4885.eurprd05.prod.outlook.com (20.177.34.225) by AM6PR05MB6470.eurprd05.prod.outlook.com (20.179.7.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Thu, 31 Jan 2019 22:35:21 +0000 Received: from AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6]) by AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6%4]) with mapi id 15.20.1558.025; Thu, 31 Jan 2019 22:35:21 +0000 From: Petr Machata To: "netdev@vger.kernel.org" CC: Ido Schimmel Subject: [PATCH net-next 07/11] selftests: forwarding: mirror_gre_vlan_bridge_1q: Fix roaming test Thread-Topic: [PATCH net-next 07/11] selftests: forwarding: mirror_gre_vlan_bridge_1q: Fix roaming test Thread-Index: AQHUubU/6M4gQmnzr0WP1mUP32R/CA== Date: Thu, 31 Jan 2019 22:35:21 +0000 Message-ID: <8429c02445bca2d70ece7412e788da7115a69039.1548973731.git.petrm@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM5PR06CA0023.eurprd06.prod.outlook.com (2603:10a6:206:2::36) To AM6PR05MB4885.eurprd05.prod.outlook.com (2603:10a6:20b:b::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [78.45.160.211] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6470; 6:beiISih5sgL42fmtRGJ7l9qVXkViDWx1xpdl3zAYGoRFldq1aGZImIYQzpy+uGJbIf5+nfIXmgnH68vwJpeXVYnqNx3TzRscUqKAsNhrn+GkVq2abcaIDSTUU42bZblOAUE+bb+Rt4PkGL+P35fbw1jkjsAUWPbzuW0BRaHn8X3mrVj20Ly8zOFJjKt8AMwnQagoGsE6hC1rgebp4lnJssUM8meU4ywkcnOw2juMo2O38Iw4qJ4gnpJuLFYKTuzMsdMyY6VOBoF58PLbFhwPQE0uKjmEy4spLbecW6A5axpz6O4Oz3Lw6PYhwQuqeQmd0nA/1ZLcBFuRcgM1POOV+saMPOagaKQWr1Z7PoHeQsdepX4l7PgKmQ1ogeHsJcQ3xTaaRzeY6lAM493I395vF6EXs7ZaSBQ+nNAaJVRGuWGpBoTqJL0OjwOR1UxcHEDgZqyMgWz/P9fl/jYTxGfjUA==; 5:6k+NQ/YWNRHRLO+bX6Z9IuS34SkPlJ2YKiKzOJwlhQJM89EV8pdSR+/kp95b8gbc3Jujwsz9uDf0LGqSRDyqIOA6qPxdXbJG7n/OpF+dQ10yuY6IepTSRK4ny8lUeNaY81GnEKMju+s2BPbmWYF7vbN1OtT2/3ZbewsbXGGuW6J/vvXhkFiaGYy/gaSau3hntF+KcjTFQNb45azTibYHmA==; 7:9IbCg73qn0drwmKvIknWzmAgOdpWjc3cJQt+aV75NzUj3S4GkUMNKGDex7gyqqFXeD6Xf5XSKnDu28XgnPrKNtmbIcalgIIfjVAVK4NW0GPxGR0FSe1wW/ZLBFkDepZElKWiHejHl3U0sQbxrxVBhg== x-ms-office365-filtering-correlation-id: a0da6cf7-ce90-4dd7-392e-08d687cc6228 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6470; x-ms-traffictypediagnostic: AM6PR05MB6470: x-microsoft-antispam-prvs: x-forefront-prvs: 09347618C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(105586002)(99286004)(6436002)(3846002)(7736002)(86362001)(6486002)(76176011)(4326008)(6116002)(305945005)(52116002)(5640700003)(36756003)(316002)(71200400001)(256004)(14444005)(71190400001)(106356001)(6916009)(25786009)(53936002)(186003)(478600001)(476003)(2616005)(118296001)(26005)(11346002)(446003)(2351001)(486006)(6512007)(107886003)(2906002)(81156014)(8936002)(1730700003)(8676002)(14454004)(2501003)(68736007)(66066001)(81166006)(6506007)(386003)(97736004)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6470; H:AM6PR05MB4885.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: U3FAcnQOQpGAVQEvmYowix2iyGYJhADRIOF1PZf9sXGQkP8w/G6Vtd6Jl4hrBfUVpw7prPCXHsPFmRX99LvHh0hsDDHSLCTkpf8AkMz4MgAMca27ckTE7x0UPMrrnC2WjFR8xmxNdQOe3lpfj9Y4K9jyA05ExbZzyOUO+zRIlNCicI7Tx77MvWglx40u5inOuBGotDb3dc1Fr9SshPKS6nN8hhWqkA9+swLpwyvzbPLJ48+RzB6MdMsiALwba0Du4nBMj3S47FBjqsr2uWxQUzz15xjyo90VPdbURQrnfLB9YCl3+aYt6FA4tjNDV18QoO0uJ+zTiO+Zhx12MyUenfzr+YQX0wEh2A22QKzyMD3UyOchrABdsyjoRzVq5InW52d7f1mG+5Z75BaIizy4s5+ACdoKZDOe7R1FqiElL60= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0da6cf7-ce90-4dd7-392e-08d687cc6228 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 22:35:20.8284 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6470 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ARP or ND traffic can cause spurious migration of FDB back to $swp3. Mirroring is then updated in accordance with the change, and mirrored packets are seen at h3, causing a failure. Detect the case of this spurious roaming, and retry the test. Signed-off-by: Petr Machata --- .../net/forwarding/mirror_gre_vlan_bridge_1q.sh | 25 ++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh b/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh index 43ee505f9f71..c02291e9841e 100755 --- a/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh +++ b/tools/testing/selftests/net/forwarding/mirror_gre_vlan_bridge_1q.sh @@ -269,12 +269,25 @@ test_span_gre_fdb_roaming() mirror_install $swp1 ingress $tundev "matchall $tcflags" quick_test_span_gre_dir $tundev ingress - bridge fdb del dev $swp3 $h3mac vlan 555 master - bridge fdb add dev $swp2 $h3mac vlan 555 master - sleep 1 - fail_test_span_gre_dir $tundev ingress - - bridge fdb del dev $swp2 $h3mac vlan 555 master + while ((RET == 0)); do + bridge fdb del dev $swp3 $h3mac vlan 555 master 2>/dev/null + bridge fdb add dev $swp2 $h3mac vlan 555 master + sleep 1 + fail_test_span_gre_dir $tundev ingress + + if ! bridge fdb sh dev $swp2 vlan 555 master \ + | grep -q $h3mac; then + printf "TEST: %-60s [RETRY]\n" \ + "$what: MAC roaming ($tcflags)" + # ARP or ND probably reprimed the FDB while the test + # was running. We would get a spurious failure. + RET=0 + continue + fi + break + done + + bridge fdb del dev $swp2 $h3mac vlan 555 master 2>/dev/null # Re-prime FDB $ARPING -I br1.555 192.0.2.130 -fqc 1 sleep 1