From patchwork Mon Jul 13 12:16:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1327919 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=E08jUUD9; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B52gp2BZlz9sRN for ; Mon, 13 Jul 2020 22:16:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729671AbgGMMQf (ORCPT ); Mon, 13 Jul 2020 08:16:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726586AbgGMMQe (ORCPT ); Mon, 13 Jul 2020 08:16:34 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDCEC061755; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id b92so6158197pjc.4; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lLOk7rW4/byxbGdkeQSwDePJbFv55lWDJWAbGgIeO8I=; b=E08jUUD9Guyz5JlCO5wNfxTPFIyn/hzpAYddrVpcRIPdARH3MJ79H0G9rkb+jcKutN dqpK/KKV+hXC1EbeA4uw6qCjoI+nBirFUDDUyyfm/Si2zu1a0nYGG+zGGUaJeXY5IFSW 3aaf6LpCIMPPlT4mOm87cgnGrzRbqZhXm14eVy7oe+cdYuiwwH79ibQNth7115eGwV0O KW9Ap0Wa4mGkKrldpWqKAvvrXVUsqkfzNaDqn/PUQDj8U9IvVzmWDsQQKaR8gDIXEtPF bxkyNnyUePp9e+cjycLDZ59UW7vsx7XGiVRvQ7nEo3pSuyIU6x9T7VmGYXiXQNQmBPYC Iemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lLOk7rW4/byxbGdkeQSwDePJbFv55lWDJWAbGgIeO8I=; b=aejy5MGUlw5xvm520vlmi/oSVOeWAZIKiKqygJzLCavAVBgd++zhHyPdGF4B+RrxZ5 jDmBVLBjazA9Wyz4HYxUaODOg2xXRBLLmiMUUM8yyFFiOhax+WXhkuAH0nqde0DkQC9O yz/t1JpyKwWQWidkbMQwWnMSzYetvmTqDDgQ7vv24YgHnwdEi2k/DqflfCFmRRNsgKvF pmO2+g9XN5pTmbKBrbJYvPFx4PSEHhZ6Gn+qobVqVexSTWtBRCspcPdKK2pTXdN1uDnf NbBp7gmomVVVxc5w2UH8Kf05epXmOBeNhbS4nZxqQdKIk0lm54mCdPvSWyVwbrEz0BAh gI8A== X-Gm-Message-State: AOAM533VERXFPqYRo5KGzVSSLE6v2WPYgsSTiAZDDIoMW1Z93E6VKq5k aebPZ75VtD3t1LuhBI2DZTGrJzOBEA8Odw== X-Google-Smtp-Source: ABdhPJxNO1ea46TfHeaFd7sxGBVN42EIq2/b736PE7owHtr4DVTpsXBHt8g8O7bkhcVKZgrNPP2ISQ== X-Received: by 2002:a17:902:243:: with SMTP id 61mr13222662plc.29.1594642594128; Mon, 13 Jul 2020 05:16:34 -0700 (PDT) Received: from blackclown ([103.88.82.220]) by smtp.gmail.com with ESMTPSA id k100sm14960073pjb.57.2020.07.13.05.16.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Jul 2020 05:16:33 -0700 (PDT) Date: Mon, 13 Jul 2020 17:46:21 +0530 From: Suraj Upadhyay To: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: qlge: qlge_dbg: Simplify while statements Message-ID: <79e35c695a80168639c073137a80804da3362301.1594642213.git.usuraj35@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_dbg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 32fbd30a6a2e..985a6c341294 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -42,9 +42,9 @@ static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg, u32 bit, u32 err_bit) { u32 temp; - int count = 10; + int count; - while (count) { + for (count = 10; count; count--) { temp = ql_read_other_func_reg(qdev, reg); /* check for errors */ @@ -53,7 +53,6 @@ static int ql_wait_other_func_reg_rdy(struct ql_adapter *qdev, u32 reg, else if (temp & bit) return 0; mdelay(10); - count--; } return -1; }