From patchwork Thu Jan 31 22:35:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 1034500 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="Ip8xn3mX"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43rFRx3WL3z9sDX for ; Fri, 1 Feb 2019 09:35:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729526AbfAaWfY (ORCPT ); Thu, 31 Jan 2019 17:35:24 -0500 Received: from mail-eopbgr70075.outbound.protection.outlook.com ([40.107.7.75]:14830 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729402AbfAaWfX (ORCPT ); Thu, 31 Jan 2019 17:35:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SylOWOgg+x8Hgo7HpVh6boXVrEdnRiX/F2/yQI18bnA=; b=Ip8xn3mXROBjNy6JnzUERKR8CMBvWlcY1B3xchYam22YrXPcH1sKm8PYlyWYlQcyu7bvHyMKljkpv6PplOtVwsTFT2WtCjP4wGQvcbZKdvsufGDlG3LzqxN0NjlXQHHkHIiiyn1fH9aQCcPBuGmiqMX19UuPwR1qljX4l8YsHqY= Received: from AM6PR05MB4885.eurprd05.prod.outlook.com (20.177.34.225) by AM6PR05MB6470.eurprd05.prod.outlook.com (20.179.7.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Thu, 31 Jan 2019 22:35:17 +0000 Received: from AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6]) by AM6PR05MB4885.eurprd05.prod.outlook.com ([fe80::3830:b2de:562:1fe6%4]) with mapi id 15.20.1558.025; Thu, 31 Jan 2019 22:35:17 +0000 From: Petr Machata To: "netdev@vger.kernel.org" CC: Ido Schimmel Subject: [PATCH net-next 05/11] selftests: forwarding: mirror_lib: Wait for tardy mirrored packets Thread-Topic: [PATCH net-next 05/11] selftests: forwarding: mirror_lib: Wait for tardy mirrored packets Thread-Index: AQHUubU9qc/Vaf1010y0ueuzSVtYJg== Date: Thu, 31 Jan 2019 22:35:17 +0000 Message-ID: <69fcd31bafd1d09cfd8031b9639e1881194a6bd9.1548973731.git.petrm@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR0102CA0014.eurprd01.prod.exchangelabs.com (2603:10a6:209:14::27) To AM6PR05MB4885.eurprd05.prod.outlook.com (2603:10a6:20b:b::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [78.45.160.211] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6470; 6:hpsnz+JLFBvpYTWghbdf5PQEnQIv8XvwE5aQxYUidFDa6G8hxOv+9On9UwdHDIzubEi9Yqo7sqmQtw5hAdoE9IFuTpU+Kgh3U0fFDTJ8bKv/GmofAwNHFGmE9AF25wxbNz4csz3qQnoHWB4th2T/6pC9LLPAMQhPxHAwuP7wVMgMOe92Vm0DTydRKBS6ngMVRmqCeEiNv+dF1aHhavNCFFFU9UU85K+XAID1ccz+E3uB8nGYJPD3vHh8WjoDF/nI2BPWgJmBjJjbrOFvYG/Lz5RGaCC7syHDO05duqYCYCbEwl4so95zXlVbbL8hmVLGh7E7xECLLYp4GLHARq0OmM/U9T9yJuEB9OLoWkMBshANbXYmsya4YuE2hS9xO9D3i259uZY7V1qtJKIO3qbxnXD9ZdNZMIq99HJxA6RKHS7LNM3gcUj5OxPjRWQmbo1ak6sA/y2ogoqOwAMS1Lx+TA==; 5:4PZFyG84YGyy4ExOXFYGkboOJG2Pvbhuuc8S5LhpIPSiS9bz3U/d06WzFcZ3SAgcGavhoz5dOR47erCqUPsChHpLfNfEMf9bMo7xWLfi9Jrnu3zj2Z8CcUOJE7D4TUH0L0TX5PzYk0jKEJZYJkzRmquGyV76URbFw9DQ2U3Z20HLx4zZhTGSjXk/J9Z3qf2FYuyJxfn+8s6AFqs2NijSvQ==; 7:SnGfVQsmGnUfRKyGw7gfgNNPPaB0+hUzPSNGujmbIE0vufUhLudveZYMt1Ga8XKyR3cfhH9qKHsPw3gCoxNrXblEteMzNy2GCO/15CJ9ZwIBGkdyb/79c/lNDZw5K3Qo+8mk07pN2gddFz+QXxoj8w== x-ms-office365-filtering-correlation-id: df93b527-93cb-48c1-8931-08d687cc5fc2 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6470; x-ms-traffictypediagnostic: AM6PR05MB6470: x-microsoft-antispam-prvs: x-forefront-prvs: 09347618C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(189003)(105586002)(99286004)(6436002)(3846002)(7736002)(86362001)(6486002)(76176011)(4326008)(6116002)(305945005)(52116002)(5640700003)(36756003)(316002)(71200400001)(256004)(71190400001)(106356001)(6916009)(25786009)(53936002)(186003)(478600001)(476003)(2616005)(118296001)(26005)(11346002)(446003)(2351001)(486006)(6512007)(107886003)(2906002)(81156014)(8936002)(1730700003)(8676002)(14454004)(2501003)(68736007)(66066001)(81166006)(6506007)(386003)(97736004)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6470; H:AM6PR05MB4885.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s3Y8A/CzQd8QK4sGXNnbqQdGjL3qykbK0JwXYeSGfZKjkO4uhhIUuEctBxrUkRZKX05PUgWHsMECxNHk+UlBgxiq9M9vvbzITWcyQ5n09mmbCG2t+G0ZdpBOM6gKv8YU5jWveCjyy8K5ePg5ugsnpgiW5s/PHoTLxysePzqwfWgVhTnedz+ZEyXi5bB4R9FPSG3jgb1J7rTMlegSAP22z1PDfNJOpxr6x/pSSpgpnHK7xtr3uy9RgSzrRiuDJhgEO2eXxO5O/Q3IhnV8VIBppAA7ryiXqOjYOmIJb7JTmYjxHCyOigJfGjXAo36cd0HEOfGzLYm7f3nivumjJ0ESkfDtehvyBbqv6IfG5KK6t4G880Q9L4nxPoZ1H1XepgmjU1h5rDvx6OL6QsyZQuIDWqvSOttWLLvUMAfLxsgaj4I= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: df93b527-93cb-48c1-8931-08d687cc5fc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 22:35:16.7485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6470 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When running in an environment with poor performance (such as a simulator), processing mirrored packets can take a while. Evaluating the condition too soon leads to spurious "seen 9, expected 10" failures as the last packet doesn't have enough time to get mirrored and the mirror to arrive and bump the observed counters. Wait for one ping interval before evaluating the test. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/mirror_lib.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/net/forwarding/mirror_lib.sh b/tools/testing/selftests/net/forwarding/mirror_lib.sh index 878f8d53327a..00797597fcf5 100644 --- a/tools/testing/selftests/net/forwarding/mirror_lib.sh +++ b/tools/testing/selftests/net/forwarding/mirror_lib.sh @@ -34,6 +34,7 @@ mirror_test() ip vrf exec $vrf_name \ ${PING} ${sip:+-I $sip} $dip -c 10 -i 0.5 -w $ping_timeout \ &> /dev/null + sleep 0.5 local t1=$(tc_rule_stats_get $dev $pref) local delta=$((t1 - t0)) # Tolerate a couple stray extra packets.