From patchwork Sat May 6 15:42:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geliang Tang X-Patchwork-Id: 759329 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wKtMs52Dwz9s8P for ; Sun, 7 May 2017 01:43:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NCbIRJuz"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbdEFPn3 (ORCPT ); Sat, 6 May 2017 11:43:29 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33202 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbdEFPm6 (ORCPT ); Sat, 6 May 2017 11:42:58 -0400 Received: by mail-pg0-f65.google.com with SMTP id s62so4604946pgc.0; Sat, 06 May 2017 08:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sC2M3U3O2I87ghT5TYDi1NtQtpeD6nAlQR978xfB4Xo=; b=NCbIRJuzywERR3btuY87MWgTFFMGzhFgA/TOTQQnvzDJelgOyZYqXzeymkgF1bDmUG CEoeFS3k6nSVSTRmako9ZIaXWW9jTlJaIb4yghMb6Qn9RNmfqR9wY0LalCFBB8J6j85E ryQ2mMKm0j5WgkDN00H1NMb2aYhU4tzARwCfaHTEoPjFxJ5qhaRogZbTmG5/WRTe/hA+ y6nDZ4ffiiX+SyciufpBv9DrvqEPq3zSoqkqhCooMM0GQbqtzUKG+mj5ITplctbQ6d3p /f5znigv/kjhPhbl7ad/KNouB+su21E5JvA1h27y91yikUS7EtDWc3QNXTrmWug9hCBa yKEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sC2M3U3O2I87ghT5TYDi1NtQtpeD6nAlQR978xfB4Xo=; b=rdzbAYs2BhTjxXc3qiEfyJawP05l97Ia/fI1bnEGp+Iq89ufF21P8LQMG7vH3hAY4O aK07uycGJTccJVMNdKIzdZCBStkeR21vZzRsBYJB8wKBZO7Uy1gqKWqOzkSd4/zoqLeb efn8efpovGxdppEYUESBg1QFeQsgh+7mEmOKUrtX+C4IpnRL/Qb3IwETD+Rx0XFeP0Va G34Z8pOYzQtAIa5eWRUZc/SmUsjMssXgjsM/5XLzhBToORYRaCI1VDdviJ2MLQOz4OQV haYARq+oeLyqRScYFj10hyFJv03i8MC1mllbBI+WWqygkvPwweveiKz0ioU+Ti2qu+HN 1olQ== X-Gm-Message-State: AN3rC/5ZcQbC6idHoHAIDAkjPVscVD95BjS2tn1IHYFftppWbujiw1b+ y+lxbJHhRoaQZQ== X-Received: by 10.84.241.206 with SMTP id t14mr15896464plm.48.1494085378091; Sat, 06 May 2017 08:42:58 -0700 (PDT) Received: from localhost (li409-196.members.linode.com. [106.187.89.196]) by smtp.gmail.com with ESMTPSA id l3sm16352240pfj.130.2017.05.06.08.42.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 May 2017 08:42:57 -0700 (PDT) From: Geliang Tang To: Kalle Valo , Colin Ian King Cc: Geliang Tang , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wlcore: use memdup_user Date: Sat, 6 May 2017 23:42:20 +0800 Message-Id: <69124563157776eb4187fa35b0161dc8675ebeaf.1493781907.git.geliangtang@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/net/wireless/ti/wlcore/debugfs.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c index de7e2a5..a2cb408 100644 --- a/drivers/net/wireless/ti/wlcore/debugfs.c +++ b/drivers/net/wireless/ti/wlcore/debugfs.c @@ -1149,15 +1149,9 @@ static ssize_t dev_mem_write(struct file *file, const char __user *user_buf, part.mem.start = *ppos; part.mem.size = bytes; - buf = kmalloc(bytes, GFP_KERNEL); - if (!buf) - return -ENOMEM; - - ret = copy_from_user(buf, user_buf, bytes); - if (ret) { - ret = -EFAULT; - goto err_out; - } + buf = memdup_user(user_buf, bytes); + if (IS_ERR(buf)) + return PTR_ERR(buf); mutex_lock(&wl->mutex); @@ -1197,7 +1191,6 @@ static ssize_t dev_mem_write(struct file *file, const char __user *user_buf, if (ret == 0) *ppos += bytes; -err_out: kfree(buf); return ((ret == 0) ? bytes : ret);