From patchwork Thu Nov 16 04:27:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838411 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TbRqVhRl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpJ34L6Sz9ryr for ; Thu, 16 Nov 2017 15:32:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759128AbdKPEcc (ORCPT ); Wed, 15 Nov 2017 23:32:32 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:43889 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932612AbdKPE3Z (ORCPT ); Wed, 15 Nov 2017 23:29:25 -0500 Received: by mail-pf0-f194.google.com with SMTP id a84so13802219pfl.0; Wed, 15 Nov 2017 20:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=R7t7+m+x62uKP90LgigSpVBXRBWwge7M1S3zc9A4x3U=; b=TbRqVhRlaEiO/wn47dcHz8dpTCsBS5FwjDMUXYzl+iGXTwMbuKqBenLEP+tge/mYfH DJX2kUjYgTdX5iaTZsK/CMqqM+BTtKfFwf5aQ0+TK3ab8VEcnKPHDTxlKOJ7+GSADk8e zeqfvhskulogWTC+Pd4WZgYI1CLDBIXkywW4IH8YdAzt2L/OOhy9C0RjD+Etjtt9L3EH GQkc2BDNldpEEPpfEaA67jKzuLKMn/+JS4FXO7JUWZptil5duVmmvcd3KtT9TnRGTF7D 3GLDdK6AEx4AuTY6sjDI/oz2HfQmnBP4yPG6VCg9PrEsxJ44L1p/jpZ9xNtUpvibCEmq KCNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=R7t7+m+x62uKP90LgigSpVBXRBWwge7M1S3zc9A4x3U=; b=hy1F2AtFKDO7Ihzv3QWluM+M6UqYoKaiHqs+NL8Lj8lrcz75n301u7FhaN56jb9Pf4 AzzIkA0DwNFB5t4adqtf8o0cnf/5C52QlmF7j+lPiE6DXY0A9isXpC9hJccfaFTBILiY hBongMKcl8Epn/F42Y6+LIguygO7Z+7oV86uUyIgsgjiAjC5NNHD+phyXJ9mZD6OtxZB 9Wp9XDuHL2Bs/EDfUzGMud2WgMpenhTD58n1u/QAvsthT8lF7s1OMfdK1ch64k2/dDcM t/VNsVt9h7TGpd3royXHFcVd9Oy1s666YKfZDWlY2EvmvIThL/OwCL2PQ6Jirvm/axMv 85cQ== X-Gm-Message-State: AJaThX6N/aWA7kuOFiusQK94sVNPzs54SuQeOpKtsRr4E6sc0/TNNTF/ jK9UqRxVGbFQh7jkTaGb0Fc= X-Google-Smtp-Source: AGs4zMZmGcR2OT1G79xKG49amqqZcFh5sBx3i/OdrPfdQC8uAoR0OrEmn9/mLfyIH4FJ/Ww9nwLpmQ== X-Received: by 10.99.154.66 with SMTP id e2mr390165pgo.287.1510806564222; Wed, 15 Nov 2017 20:29:24 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:23 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 12/12] isdn: hisax: Fix pnp_irq's error checking for setup_teles3 Date: Thu, 16 Nov 2017 09:57:29 +0530 Message-Id: <685ec4c014979a2a93303195c14e631c3c54f107.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/teles3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/teles3.c b/drivers/isdn/hisax/teles3.c index 38fb2c1..1eef693 100644 --- a/drivers/isdn/hisax/teles3.c +++ b/drivers/isdn/hisax/teles3.c @@ -306,7 +306,7 @@ int setup_teles3(struct IsdnCard *card) card->para[2] = pnp_port_start(pnp_d, 1); card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1] || !card->para[2]) { + if (card->para[0] == -1 || !card->para[1] || !card->para[2]) { printk(KERN_ERR "Teles PnP:some resources are missing %ld/%lx/%lx\n", card->para[0], card->para[1], card->para[2]); pnp_disable_dev(pnp_d);