From patchwork Tue Nov 14 08:12:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 837715 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Pye7Nllf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ybgJL40Kxz9sP1 for ; Tue, 14 Nov 2017 19:13:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbdKNINm (ORCPT ); Tue, 14 Nov 2017 03:13:42 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:53916 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbdKNINj (ORCPT ); Tue, 14 Nov 2017 03:13:39 -0500 Received: by mail-pf0-f193.google.com with SMTP id b6so13620425pff.10; Tue, 14 Nov 2017 00:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hmRiYkhzCQroiacsjTxRMLSY50LT6/T1F/IKj0uhWoc=; b=Pye7NllftMN3gh6oxlzmgoj0oCmr6N7lfk8boELnqTrtkzvnA5PH/XHSNZ5JMV3nYP MIjIkiTdS8ZbkBagwkkMfM4l1FMGa4cxpyGegfCud10jMBaI/dlP0Nwwxl8R2DCNnX/l 1osFtzM70IRy6eKooad7lmz/Dh2FU7IE85jKEFV3S1sbkv34KE2rP+26bJ9A5tHDhwIK zWcHqLliUrXcYFpQMeGvcwdB4RXQWFdAlkGdFPYU5rZ9R5AMX1Mc5/Qz+AmHzZBQi8nO JgJfmVv+y/ar9VrAaP1pMh6Jmpl89d/6p0rFxinAZGEB5pe8kjrMf1C7m1GFwOa2W6OX MOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hmRiYkhzCQroiacsjTxRMLSY50LT6/T1F/IKj0uhWoc=; b=l3BX7H1FrxXVSXJkxFHnZfqHV1Z5egPRN5bH6PSYHMxNgIOH6eubSE2l8vTRQopcv+ NRPdoJyEp9FaJP9nDDGwnisaz06XJbrsRs7OGWcdah/Sw1yn4rBRbjDhKUd1fbH3QIon zqOOwrBKUbDAV2A7hKN52H7HiDQ7knOCFPoPuYEfHtuSECD1C9mDU9AFcU+fu4/8MsLY pjZ608r7AscFwRQ6TpzxrfdndanWRmmRTdFdDCNwvbEQShLuesXYzq+shSnYsd/3muRk 9w7bXPigD89ETHmP42HGu/F1ZP1NnQrZ0BSBWmGwaPzFKPnEK0cS+FLBBAQjPiC7SHN9 attg== X-Gm-Message-State: AJaThX7GIFw+sRQhiYx6VM0QFdGWl+Yw6TLDsQnnsOON63YRUO2/RwXR wU3KlSGjaiuVoReZc9midZs= X-Google-Smtp-Source: AGs4zMZ+FTuBQFpuxdp0MslPWD0I2LvOG9pGX5vRUB1ljbCkQHbrLkND2ulWAP1RooQYOLl48csakQ== X-Received: by 10.101.72.1 with SMTP id h1mr11485910pgs.249.1510647218464; Tue, 14 Nov 2017 00:13:38 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id 125sm35144188pff.14.2017.11.14.00.13.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Nov 2017 00:13:34 -0800 (PST) From: Arvind Yadav To: 3chas3@gmail.com, davem@davemloft.net Cc: linux-kernel@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH] atm: horizon: Fix irq release error Date: Tue, 14 Nov 2017 13:42:38 +0530 Message-Id: <5fc117e8337d03c5bb964de50d000a9ca710c304.1510646818.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org atm_dev_register() can fail here and passed parameters to free irq which is not initialised. Initialization of 'dev->irq' happened after the 'goto out_free_irq'. So using 'irq' insted of 'dev->irq' in free_irq(). Signed-off-by: Arvind Yadav --- drivers/atm/horizon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c index 7e76b35..e121b84 100644 --- a/drivers/atm/horizon.c +++ b/drivers/atm/horizon.c @@ -2803,7 +2803,7 @@ static int hrz_probe(struct pci_dev *pci_dev, return err; out_free_irq: - free_irq(dev->irq, dev); + free_irq(irq, dev); out_free: kfree(dev); out_release: