From patchwork Mon Nov 6 13:23:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Averin X-Patchwork-Id: 834721 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yVtYs23Srz9s7M for ; Tue, 7 Nov 2017 00:24:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753010AbdKFNX7 (ORCPT ); Mon, 6 Nov 2017 08:23:59 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:31598 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbdKFNX6 (ORCPT ); Mon, 6 Nov 2017 08:23:58 -0500 Received: from [172.16.24.21] (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id vA6DNpsw030341; Mon, 6 Nov 2017 16:23:51 +0300 (MSK) From: Vasily Averin Subject: [PATCH v3 04/21] ppp: exit_net cleanup checks added To: Linux Kernel Network Developers Cc: linux-ppp@vger.kernel.org, Paul Mackerras References: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Message-ID: <5e005fe5-e8b2-eee8-b185-a9e5fc1d7996@virtuozzo.com> Date: Mon, 6 Nov 2017 16:23:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Be sure that lists initialized in net_init hook were return to initial state. Signed-off-by: Vasily Averin Signed-off-by: Dan Carpenter --- drivers/net/ppp/ppp_generic.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index e365866..c0861d1 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -960,6 +960,12 @@ static __net_exit void ppp_exit_net(struct net *net) rtnl_unlock(); idr_destroy(&pn->units_idr); + WARN_ONCE(!list_empty(&pn->all_channels), + "net %x %s: all_channels list is not empty\n", + net->ns.inum, __func__); + WARN_ONCE(!list_empty(&pn->new_channels), + "net %x %s: new_channels list is not empty\n", + net->ns.inum, __func__); } static struct pernet_operations ppp_net_ops = {