From patchwork Fri Nov 4 18:22:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Frias X-Patchwork-Id: 691382 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t9VZ43kXDz9vDk for ; Sat, 5 Nov 2016 05:22:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=laposte.net header.i=@laposte.net header.b="mAmsiYH2"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938731AbcKDSWe (ORCPT ); Fri, 4 Nov 2016 14:22:34 -0400 Received: from smtpoutz29.laposte.net ([194.117.213.104]:47123 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S936310AbcKDSWd (ORCPT ); Fri, 4 Nov 2016 14:22:33 -0400 Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout017 (Postfix) with ESMTP id 7DEF8A01CA0 for ; Fri, 4 Nov 2016 19:22:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=mail0; t=1478283751; bh=9xAHQ8sktI5P9XPezO//q+Qn+opDRB78pD77bHUmlw0=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=mAmsiYH2lziF/h0XRDpyXH5Cx0tMzKovyaoEYl0L/Ay28N29vSQVQfRKYksfCkzM5 VIcqzeEaLX4dp479nURH+XL/ZwCNqSfiVI/zuJ0amTvUAGWmGrUuLG0AVOZfoBYURk jUfxJbMnJJI8C6x7KrG5D2PljHgGOUiSsCkhn7QCaWjKgVHAOeNFB86UlWWKUxgqmk c05h/2xIkkGJiNSdbPhNtQeAZm4vZpLQW6tA6aHJyGMvOhilRQO7QiIwMBeJTIxRVM qAii+/qr2GeZ0h86elKDZGBvlQAXPR50Zzv611dAR3/MvGZbxlzEKci1XUoc3YksEn es6tySw/mIdbQ== Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout017 (Postfix) with ESMTP id 70472A01D5A for ; Fri, 4 Nov 2016 19:22:31 +0100 (CET) Received: from lpn-prd-vrin003 (lpn-prd-vrin003.laposte [10.128.63.4]) by lpn-prd-vrout017 (Postfix) with ESMTP id 6DE7BA01CA0 for ; Fri, 4 Nov 2016 19:22:31 +0100 (CET) Received: from lpn-prd-vrin003 (localhost [127.0.0.1]) by lpn-prd-vrin003 (Postfix) with ESMTP id 5643748E06E for ; Fri, 4 Nov 2016 19:22:31 +0100 (CET) Received: from [172.27.0.214] (APuteaux-554-1-100-170.w92-154.abo.wanadoo.fr [92.154.11.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lpn-prd-vrin003 (Postfix) with ESMTPSA id 096D048E062; Fri, 4 Nov 2016 19:22:31 +0100 (CET) Subject: [PATCH v3 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , "David S. Miller" , netdev References: <581CD1AF.6030300@laposte.net> Cc: LKML , Mason , Andrew Lunn From: Sebastian Frias Message-ID: <581CD1E6.60801@laposte.net> Date: Fri, 4 Nov 2016 19:22:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <581CD1AF.6030300@laposte.net> X-VR-SrcIP: 92.154.11.170 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelvddrkeelgdduudehucetufdoteggodetrfdotffvucfrrhho X-VR-Cause-2: fhhilhgvmecunfetrffquffvgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhht X-VR-Cause-3: shculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejrgdttdefjeenucfhrhhomhep X-VR-Cause-4: ufgvsggrshhtihgrnhcuhfhrihgrshcuoehsfhekgeeslhgrphhoshhtvgdrnhgvtheqnecukfhppeel X-VR-Cause-5: vddrudehgedruddurddujedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghloheplgdu X-VR-Cause-6: jedvrddvjedrtddrvddugegnpdhinhgvthepledvrdduheegrdduuddrudejtddpmhgrihhlfhhrohhm X-VR-Cause-7: pehsfhekgeeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopehmrghnshesmhgrnhhsrhdrtghomh X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index b59aa35..d2855c9 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev) break; case PHY_INTERFACE_MODE_RGMII_TXID: - pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY; + pad_mode = PAD_MODE_RGMII; break; default: