From patchwork Fri Nov 4 15:02:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Frias X-Patchwork-Id: 691280 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t9Q741xNYz9vG0 for ; Sat, 5 Nov 2016 02:02:40 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=laposte.net header.i=@laposte.net header.b="j6VRYEPX"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935179AbcKDPC2 (ORCPT ); Fri, 4 Nov 2016 11:02:28 -0400 Received: from smtpoutz27.laposte.net ([194.117.213.102]:40193 "EHLO smtp.laposte.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934112AbcKDPC1 (ORCPT ); Fri, 4 Nov 2016 11:02:27 -0400 Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout015 (Postfix) with ESMTP id 09FD01C91CF for ; Fri, 4 Nov 2016 16:02:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=mail0; t=1478271745; bh=9xAHQ8sktI5P9XPezO//q+Qn+opDRB78pD77bHUmlw0=; h=To:Cc:From:Subject:Date; b=j6VRYEPX0ppe8faZfWBQpSYwN8zx0FGJps1Q6oGoOO9ZIAWKnzHGOOhtFO9+arQ1l t2FxGlucIhYzk1aoCMuPfoK5mcchrYUDWB2I+VRDS1e6IAqiy6YxM95CG1FQnlKwXa KGhyt0BLdc2tHGJMGYsmIVhusox+GuI3Yrm1oRIE/XCHZAJYsbUaG3xsnIEWRUK++5 ffiNqpw/xwq3/9yj66z2q11w6aW+HbFdYXKKaW1kAIymnP48NswexRN/SXUwV8GkTf xowN1jEVF+ZcNw3KOF35GmT5MZFmtFT6kn4bYcdrajfubhpTC6Qqr6MFJCbB2L8DeC Z1IW6qFL69UKg== Received: from smtp.laposte.net (localhost [127.0.0.1]) by lpn-prd-vrout015 (Postfix) with ESMTP id EF5C41C9296 for ; Fri, 4 Nov 2016 16:02:24 +0100 (CET) Received: from lpn-prd-vrin001 (lpn-prd-vrin001.prosodie [10.128.63.2]) by lpn-prd-vrout015 (Postfix) with ESMTP id EAAB31C91CF for ; Fri, 4 Nov 2016 16:02:24 +0100 (CET) Received: from lpn-prd-vrin001 (localhost [127.0.0.1]) by lpn-prd-vrin001 (Postfix) with ESMTP id CC367366D3A for ; Fri, 4 Nov 2016 16:02:24 +0100 (CET) Received: from [172.27.0.214] (APuteaux-554-1-100-170.w92-154.abo.wanadoo.fr [92.154.11.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lpn-prd-vrin001 (Postfix) with ESMTPSA id 37CD7366CD4; Fri, 4 Nov 2016 16:02:24 +0100 (CET) To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= , "David S. Miller" , netdev Cc: LKML , Mason , Andrew Lunn From: Sebastian Frias Subject: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Message-ID: <581CA300.1060609@laposte.net> Date: Fri, 4 Nov 2016 16:02:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 X-VR-SrcIP: 92.154.11.170 X-VR-FullState: 0 X-VR-Score: -100 X-VR-Cause-1: gggruggvucftvghtrhhoucdtuddrfeelvddrkeelgdejgecutefuodetggdotefrodftvfcurfhrohhf X-VR-Cause-2: ihhlvgemucfntefrqffuvffgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhs X-VR-Cause-3: ucdlqddutddtmdenucfjughrpefvhffukffffgggtgfgsehtjegrtddtfeejnecuhfhrohhmpefuvggs X-VR-Cause-4: rghsthhirghnucfhrhhirghsuceoshhfkeegsehlrghpohhsthgvrdhnvghtqeenucfkphepledvrddu X-VR-Cause-5: heegrdduuddrudejtdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopegludejvddr X-VR-Cause-6: vdejrddtrddvudegngdpihhnvghtpeelvddrudehgedruddurddujedtpdhmrghilhhfrhhomhepshhf X-VR-Cause-7: keegsehlrghpohhsthgvrdhnvghtpdhrtghpthhtohepmhgrnhhssehmrghnshhrrdgtohhm X-VR-AvState: No X-VR-State: 0 X-VR-State: 0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias --- drivers/net/ethernet/aurora/nb8800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c index b59aa35..d2855c9 100644 --- a/drivers/net/ethernet/aurora/nb8800.c +++ b/drivers/net/ethernet/aurora/nb8800.c @@ -1282,7 +1282,7 @@ static int nb8800_tangox_init(struct net_device *dev) break; case PHY_INTERFACE_MODE_RGMII_TXID: - pad_mode = PAD_MODE_RGMII | PAD_MODE_GTX_CLK_DELAY; + pad_mode = PAD_MODE_RGMII; break; default: