From patchwork Sat Dec 16 19:47:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 849549 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H8ynmUSD"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yzdB23g4Lz9s03 for ; Sun, 17 Dec 2017 06:47:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757008AbdLPTrg (ORCPT ); Sat, 16 Dec 2017 14:47:36 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37394 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756815AbdLPTrd (ORCPT ); Sat, 16 Dec 2017 14:47:33 -0500 Received: by mail-pf0-f194.google.com with SMTP id n6so8073438pfa.4; Sat, 16 Dec 2017 11:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=0nflLPVMD28Vdb+8K+VHYBZkTAEf6dRabGx9W9cUoeU=; b=H8ynmUSDK7cCAXfjma5/TiD7YT6og7dVWzJT4GGIG6qElNuX8rPQ+8nLd/MU22cHfT 5MuZdC6EfaNapaOYMYQwuz8wcHhja06+/TZ+MtlArxFok4tw1A/kYQYZjd3BpF9bUiPI IBfb4I2bfc59mYJVMZqzyC1unuv2g2aB4K23krWvAzt7IuaKVEjfOi4sP8WUXiUnzctw wPX3BrDuUFiG5ClV20atYLCGaoc5zxNj+OGg6vl3ATYQglVJ4RrCF/Kg3Um/U5m0OmqH B2WZbktRFSuepK0CGV79eudFyQnM7A4Y8zN4EYLJ5yzMGP0cG81jJ72/XsQzkkVMJjU2 jC8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0nflLPVMD28Vdb+8K+VHYBZkTAEf6dRabGx9W9cUoeU=; b=crYIHEZwrjybYSWJAP9q86mQmc+Zp33OisN5frKrJe2gwVvUnSJDQI98E5zQFvfHtm iepKe6uqLNPQVvLLkut+aOLkpxKSIXHyrmoZJaDuUHVcaZA8nwx2StCc4gEh4ibwH4+o IXCahQNpgv5UfLntZUN9rbBa7JbnjiOHAyp0YXqUTQEP1lrJJ/JdSekumnjuW0uxvZpY gK+9I/eWs/le7TJr4D7oubMwXTePIZkb5NpZ15oyEn4uxOoxOPGTyAgSPmv29T2GnYTV gE8uSDJmTRUhrbzSQE5racvIp4hAjk4Gu+85KdMStG+v4YQnUdAm1sTIn7ypFArfzCK9 bw+w== X-Gm-Message-State: AKGB3mIDF1k5g4cHQepUmPsrMLJ1S5qKQqtOubIHEKZ25LuxVsy19Z9D qAfv4gvpPpLFFEbGwqBDsrnW3Q== X-Google-Smtp-Source: ACJfBosDuRGqLkTxwj/DPQt7PYhIsBdr4LGPt4Gr7Rl8hIyeoy1QrKAM0Qs0ZqlWeOoEEEA5Z+V3VA== X-Received: by 10.98.13.133 with SMTP id 5mr17400201pfn.112.1513453653237; Sat, 16 Dec 2017 11:47:33 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id l73sm18632386pfi.82.2017.12.16.11.47.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 16 Dec 2017 11:47:32 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, stephen@networkplumber.org, davem@davemloft.net, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] isdn: avm: Handle return value of skb_dequeue() Date: Sun, 17 Dec 2017 01:17:23 +0530 Message-Id: <5818ec104ed4354db3625ac8c7741d771719e4d4.1513453258.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb_dequeue() will return NULL for an empty list or a pointer to the head element. Signed-off-by: Arvind Yadav --- drivers/isdn/hardware/avm/b1dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/hardware/avm/b1dma.c b/drivers/isdn/hardware/avm/b1dma.c index 9538a9e..10df578 100644 --- a/drivers/isdn/hardware/avm/b1dma.c +++ b/drivers/isdn/hardware/avm/b1dma.c @@ -375,6 +375,8 @@ static void b1dma_dispatch_tx(avmcard *card) void *p; skb = skb_dequeue(&dma->send_queue); + if (!skb) + return; len = CAPIMSG_LEN(skb->data);