From patchwork Tue Nov 10 15:51:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 542505 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C7AF1141419 for ; Wed, 11 Nov 2015 02:53:13 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre_com.20150623.gappssmtp.com header.i=@baylibre_com.20150623.gappssmtp.com header.b=wn4pzB94; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753969AbbKJPvg (ORCPT ); Tue, 10 Nov 2015 10:51:36 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:32935 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbbKJPve (ORCPT ); Tue, 10 Nov 2015 10:51:34 -0500 Received: by wmec201 with SMTP id c201so140395009wme.0 for ; Tue, 10 Nov 2015 07:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre_com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=jkJbxHtNlwqOzS/xzF8e/9XuWmItNXGqYfDBqes88zM=; b=wn4pzB94A+VG1tr2JzR6YG0L9Ix1X9bNkWEoetulxwKS4Gg0MC0KTM4qpzaGWtXd2N /4vhEKEx/3C/7Lhy0WzIyeG8GTH/CxV86/E3XHM2zAGr6goOCg2KIF/YgcyEjFlZoOyi yh8sImA80j6yRFi+98qV3/H06qAHcX/vHmTh8AfTVyRTMQUQXHL9DceeV9yEZZsIfebK 8157D0fYhNwWJUiNB/jtTuF0LetViuSX6vdLbXXQrK+YoEe+F8CMe8ejUviWatYgznpu cmejQ/FWvQ1E0cbumYmRUG0VYYqGL5oMj+T7ClMwRf8RCQjguWlLpYekVGh0kdmb5jgG Jdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:cc:organization:message-id:date :user-agent:mime-version:content-type:content-transfer-encoding; bh=jkJbxHtNlwqOzS/xzF8e/9XuWmItNXGqYfDBqes88zM=; b=YUhlvPtbsauVtg3btIySoLiY6f+/LehFVnMUwLIlBDC6VMBzmitWPJKAFzUQG6ytK4 gf3okt9bd9TVV4g2Am8fww3sZZto8mmCr19N0mN8TETmJmVyZakxIdNnjv7KuF8o3x5L mnGHy4QAnjTi04FedSpeGQbgV3U90lbDX5XoHYmvTB6OUEuiEL92RzWCnJYCKCCzHk93 S9iwz6cTwlIDKXJiWIANiI4l6O2WCYoQLMRRV8rwwfdugiorZGK5ry2maQGkblhLT1Tn oSX63eck8u5mBvD4RgjK6Gfp8FIoutxZnhAazsb8K+QLxN5/UHl2HfOj2mVrb0WYj23Y WwGg== X-Gm-Message-State: ALoCoQnjBdQFeItIDydIocjXK98QzWuXbiCMotqax70moT6VK2wN3jajxt1j8hemNqYe9VwdVMeZ X-Received: by 10.28.129.82 with SMTP id c79mr5943499wmd.80.1447170693640; Tue, 10 Nov 2015 07:51:33 -0800 (PST) Received: from [192.168.1.21] ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id h7sm4180288wjz.7.2015.11.10.07.51.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 07:51:32 -0800 (PST) From: Neil Armstrong Subject: [PATCH v2 3/6] net: dsa: mv88e6060: use the correct MaxFrameSize bit To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Florian Fainelli , Andrew Lunn , Guenter Roeck , Neil Armstrong , Vivien Didelot Organization: Baylibre Message-ID: <5642127C.4090703@baylibre.com> Date: Tue, 10 Nov 2015 16:51:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org According to the mv88e6060 datasheet, the MaxFrameSize bit position is 10 instead of 11 which is reserved. Use the bit correctly to setup max frame size to 1536. Acked-by: Andrew Lunn Signed-off-by: Neil Armstrong --- drivers/net/dsa/mv88e6060.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index eff5e18..10647ad 100644 --- a/drivers/net/dsa/mv88e6060.c +++ b/drivers/net/dsa/mv88e6060.c @@ -119,7 +119,7 @@ static int mv88e6060_setup_global(struct dsa_switch *ds) * set the maximum frame size to 1536 bytes, and mask all * interrupt sources. */ - REG_WRITE(REG_GLOBAL, 0x04, 0x0800); + REG_WRITE(REG_GLOBAL, 0x04, 0x400); /* Enable automatic address learning, set the address * database size to 1024 entries, and set the default aging