From patchwork Fri Jan 16 11:45:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Borkmann X-Patchwork-Id: 429822 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2CE7A1401DA for ; Fri, 16 Jan 2015 22:45:42 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754546AbbAPLpi (ORCPT ); Fri, 16 Jan 2015 06:45:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34471 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754525AbbAPLpd (ORCPT ); Fri, 16 Jan 2015 06:45:33 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0GBjUYm015817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 16 Jan 2015 06:45:30 -0500 Received: from [10.36.7.167] (vpn1-7-167.ams2.redhat.com [10.36.7.167]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0GBjQ1g026193 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 16 Jan 2015 06:45:28 -0500 Message-ID: <54B8F9D6.4050202@redhat.com> Date: Fri, 16 Jan 2015 12:45:26 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Marcelo Ricardo Leitner CC: Or Gerlitz , netdev Subject: Re: Compile-time warnings on mlx4/net-next References: <54B7BB17.8090308@redhat.com> <54B7BEAF.6000406@mellanox.com> <54B7C2EB.8010007@redhat.com> In-Reply-To: <54B7C2EB.8010007@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/15/2015 02:38 PM, Marcelo Ricardo Leitner wrote: > On 15-01-2015 11:20, Or Gerlitz wrote: ... >>> Do you see them too? >> >> using $ make W=1 -j 20 SUBDIRS=./drivers/net/ethernet/mellanox/mlx4 with gcc >> 4.8.2 I don't see that, but I'll look there, >> thanks for the report. I believe they are there for quite some time already. I'm using gcc 4.8.3 and just default build. I'm surprised Fengguang didn't complain yet (or he did, but it got ignored somehow ;)). The following should be sufficient to just shut gcc up: --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 982861d..b01154d 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2122,6 +2122,7 @@ int mlx4_config_dev_retrieval(struct mlx4_dev *dev, if (!(dev->caps.flags2 & MLX4_DEV_CAP_FLAG2_CONFIG_DEV)) return -ENOTSUPP; + memset(&config_dev, 0, sizeof(config_dev)); err = mlx4_CONFIG_DEV_get(dev, &config_dev); if (err) return err;