From patchwork Tue Jun 10 00:40:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 357650 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 36DF1140077 for ; Tue, 10 Jun 2014 10:40:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934543AbaFJAke (ORCPT ); Mon, 9 Jun 2014 20:40:34 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:25426 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933181AbaFJAkc (ORCPT ); Mon, 9 Jun 2014 20:40:32 -0400 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie3.idc.renesas.com with ESMTP; 10 Jun 2014 09:40:30 +0900 Received: from relmlac3.idc.renesas.com (relmlac3.idc.renesas.com [10.200.69.23]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 5947E429C1; Tue, 10 Jun 2014 09:40:30 +0900 (JST) Received: by relmlac3.idc.renesas.com (Postfix, from userid 0) id 461F5180A4; Tue, 10 Jun 2014 09:40:30 +0900 (JST) Received: from relmlac3.idc.renesas.com (localhost [127.0.0.1]) by relmlac3.idc.renesas.com (Postfix) with ESMTP id 416EF180A0; Tue, 10 Jun 2014 09:40:30 +0900 (JST) Received: from relmlii2.idc.renesas.com [10.200.68.66] by relmlac3.idc.renesas.com with ESMTP id KAH30711; Tue, 10 Jun 2014 09:40:30 +0900 X-IronPort-AV: E=Sophos;i="4.98,1005,1392130800"; d="scan'208";a="162752673" Received: from mail-hk1lp0117.outbound.protection.outlook.com (HELO APAC01-HK1-obe.outbound.protection.outlook.com) ([207.46.51.117]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES128-SHA; 10 Jun 2014 09:40:29 +0900 Received: from [10.161.20.55] (211.11.155.147) by HKNPR06MB321.apcprd06.prod.outlook.com (10.141.38.15) with Microsoft SMTP Server (TLS) id 15.0.959.24; Tue, 10 Jun 2014 00:40:28 +0000 Message-ID: <539653F8.6020603@renesas.com> Date: Tue, 10 Jun 2014 09:40:24 +0900 From: Yoshihiro Shimoda User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: "netdev@vger.kernel.org" CC: SH-Linux , Sergei Shtylyov Subject: [PATCH v2 2/2] net: sh_eth: Fix timing of RACT setting in sh_eth_rx() X-Originating-IP: [211.11.155.147] X-ClientProxiedBy: SINPR04CA010.apcprd04.prod.outlook.com (10.242.48.40) To HKNPR06MB321.apcprd06.prod.outlook.com (10.141.38.15) X-Microsoft-Antispam: BCL:0;PCL:0;RULEID: X-Forefront-PRVS: 0238AEEDB0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(6009001)(6049001)(428001)(199002)(189002)(4396001)(66066001)(81542001)(64126003)(46102001)(87976001)(42186004)(76482001)(21056001)(50466002)(102836001)(81342001)(65956001)(47776003)(77982001)(20776003)(31966008)(101416001)(92726001)(36756003)(74502001)(99396002)(99136001)(54356999)(50986999)(64706001)(92566001)(65816999)(65806001)(79102001)(80022001)(83506001)(83072002)(86362001)(74662001)(87266999)(33656002)(83322001)(19580405001)(19580395003)(85852003)(23756003)(59896001); DIR:OUT; SFP:; SCL:1; SRVR:HKNPR06MB321; H:[10.161.20.55]; FPR:; MLV:sfv; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; X-OriginatorOrg: renesas.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes an issue that we cannot use nfs rootfs correctly on r8a7790 when the command below runs on a host PC. $ sudo ping -f -l 8 $BOARD_IP_ADDR Since the driver sets the RACT to 1 in the first while loop of sh_eth_rx(), the controller accepts a next frame into the next RX descriptor during the while loop. But, in the first while loop doesn't allocate a next skb. So, this patch removes the RACT setting in the first while loop of sh_eth_rx(). Signed-off-by: Yoshihiro Shimoda --- drivers/net/ethernet/renesas/sh_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 5761f8c..621c581 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -1460,7 +1460,6 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota) ndev->stats.rx_packets++; ndev->stats.rx_bytes += pkt_len; } - rxdesc->status |= cpu_to_edmac(mdp, RD_RACT); entry = (++mdp->cur_rx) % mdp->num_rx_ring; rxdesc = &mdp->rx_ring[entry]; }