From patchwork Wed May 21 00:19:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 350907 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9DC68140086 for ; Wed, 21 May 2014 10:20:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbaEUATn (ORCPT ); Tue, 20 May 2014 20:19:43 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:44221 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750737AbaEUATl (ORCPT ); Tue, 20 May 2014 20:19:41 -0400 Received: by mail-pd0-f179.google.com with SMTP id x10so811220pdj.10 for ; Tue, 20 May 2014 17:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=vquFZ3lSqftN25gtTRdhwpi8p487N5MW42AOuU/ltvc=; b=z9TSbxPSZBOzxkzAGEImmWXVmkuR9uz5+LWvmDjxMIcIrv8/Cs/l8I+Emfh71kw0YG U8jqubmKDCQOisb2fZ/LdNXj51AozyDHX8qYX/W99ODypsCaeSqUjoANzBng6vlAFC3p t1qF9HxIO3uwJHMskTn//t0sJVjLjwSC0bCbvHUTpLvSs3agjQdzyOSKrgVzCyjTa13l YwEYxeBs3QhwCO8VDLvYfAw8kYJEgO1fA8JE0TlpdbHkenlIJF3RjpFUAMccZ4tVJ6rX R4FmAOWo5oUhPpbQzn5D0CMTNX9RECELHwDP9Ahm5kD8hYbF6rR0z6TpARd0PCXCMvow Pf2Q== X-Received: by 10.66.230.193 with SMTP id ta1mr55557986pac.29.1400631581177; Tue, 20 May 2014 17:19:41 -0700 (PDT) Received: from [192.168.1.119] ([124.127.118.42]) by mx.google.com with ESMTPSA id ja8sm5078977pbd.3.2014.05.20.17.19.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 20 May 2014 17:19:40 -0700 (PDT) Message-ID: <537BF116.9000900@gmail.com> Date: Wed, 21 May 2014 08:19:34 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: gerrit@erg.abdn.ac.uk CC: Guan Xuetao , David Miller , dccp@vger.kernel.org, netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: [PATCH linux-next] net/dccp/timer.c: use 'u64' instead of 's64' to avoid compiler's warning Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 'dccp_timestamp_seed' is initialized once by ktime_get_real() in dccp_timestamping_init(). It is always less than ktime_get_real() in dccp_timestamp(). Then, ktime_us_delta() in dccp_timestamp() will always return positive number. So can use manual type cast to let compiler and do_div() know about it to avoid warning. The related warning (with allmodconfig under unicore32): CC [M] net/dccp/timer.o net/dccp/timer.c: In function ‘dccp_timestamp’: net/dccp/timer.c:285: warning: comparison of distinct pointer types lacks a cast Signed-off-by: Chen Gang --- net/dccp/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dccp/timer.c b/net/dccp/timer.c index 16f0b22..1cd46a3 100644 --- a/net/dccp/timer.c +++ b/net/dccp/timer.c @@ -280,7 +280,7 @@ static ktime_t dccp_timestamp_seed; */ u32 dccp_timestamp(void) { - s64 delta = ktime_us_delta(ktime_get_real(), dccp_timestamp_seed); + u64 delta = (u64)ktime_us_delta(ktime_get_real(), dccp_timestamp_seed); do_div(delta, 10); return delta;