From patchwork Thu Feb 4 20:11:19 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 44544 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 35061B7D5A for ; Fri, 5 Feb 2010 07:13:14 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757313Ab0BDUNF (ORCPT ); Thu, 4 Feb 2010 15:13:05 -0500 Received: from e24smtp03.br.ibm.com ([32.104.18.24]:60068 "EHLO e24smtp03.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753865Ab0BDUNB (ORCPT ); Thu, 4 Feb 2010 15:13:01 -0500 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp03.br.ibm.com (8.14.3/8.13.1) with ESMTP id o14K9a5Y003327 for ; Thu, 4 Feb 2010 18:09:36 -0200 Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o14KFUTL2306104 for ; Thu, 4 Feb 2010 18:15:32 -0200 Received: from d24av04.br.ibm.com (loopback [127.0.0.1]) by d24av04.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o14KCunM030940 for ; Thu, 4 Feb 2010 18:12:56 -0200 Received: from localhost.localdomain (sanx1002.austin.ibm.com [9.3.118.34]) by d24av04.br.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o14KCrUb030897; Thu, 4 Feb 2010 18:12:55 -0200 From: leitao@linux.vnet.ibm.com To: ron.mercer@qlogic.com Cc: netdev@vger.kernel.org, Breno Leitao Subject: [PATCH 2/2] qlge: Code clean up Date: Thu, 4 Feb 2010 14:11:19 -0600 Message-Id: <5283aff9bf39e3e4282575f27a51b711f7e69010.1265314112.git.root@sanx1002.austin.ibm.com> X-Mailer: git-send-email 1.6.0.2 In-Reply-To: <48284d15bf68cb154cf3948f3fd0b8ea11981ff3.1265314112.git.root@sanx1002.austin.ibm.com> References: <48284d15bf68cb154cf3948f3fd0b8ea11981ff3.1265314112.git.root@sanx1002.austin.ibm.com> In-Reply-To: <48284d15bf68cb154cf3948f3fd0b8ea11981ff3.1265314112.git.root@sanx1002.austin.ibm.com> References: <48284d15bf68cb154cf3948f3fd0b8ea11981ff3.1265314112.git.root@sanx1002.austin.ibm.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Just reordering this assignment that doesn't depend on any condition. Signed-off-by: Breno Leitao --- drivers/net/qlge/qlge_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c index c583fb5..0d6e6f8 100644 --- a/drivers/net/qlge/qlge_main.c +++ b/drivers/net/qlge/qlge_main.c @@ -4129,12 +4129,12 @@ static int qlge_change_mtu(struct net_device *ndev, int new_mtu) queue_delayed_work(qdev->workqueue, &qdev->mpi_port_cfg_work, 3*HZ); + ndev->mtu = new_mtu; + if (!netif_running(qdev->ndev)) { - ndev->mtu = new_mtu; return 0; } - ndev->mtu = new_mtu; status = ql_change_rx_buffers(qdev); if (status) { QPRINTK(qdev, IFUP, ERR,